Cover missing line in ArrayDeserializer

Author: JulianVennen

src/ArrayDeserializer.php

@@ -203,36 +203,49 @@ protected function  parseNamedType(
         string              $name
     ): mixed
     {
+        $propertyPath = $path . "." . $name;
+
         if ($type->isBuiltin()) {
-            $valid = match ($type->getName()) {
-                "bool" => is_bool($value),
-                "int" => is_int($value),
-                "float" => is_float($value) || is_int($value),
-                "string" => is_string($value),
-                "mixed" => true,
-                "array" => is_array($value),
-                "object" => is_object($value),
-                "false" => $value === false,
-                "true" => $value === true,
-                default => throw new UnsupportedTypeException($path . "." . $name, $type->getName()),
-            };
-
-            if (!$valid) {
-                throw new IncorrectTypeException($path . "." . $name, $type->getName(), $value);
+            if (!$this->isBuiltInTypeValid($type->getName(), $value, $propertyPath)) {
+                throw new IncorrectTypeException($propertyPath, $type->getName(), $value);
             }
 
             return $value;
         }
 
         if (!is_array($value)) {
-            throw new IncorrectTypeException($path . "." . $name, $type->getName(), $value);
+            throw new IncorrectTypeException($propertyPath, $type->getName(), $value);
         }
 
         if ($type->getName() === "self") {
             $deserializer = $this;
         } else {
             $deserializer = new static($type->getName());
         }
-        return $deserializer->deserialize($value, $path . "." . $name);
+        return $deserializer->deserialize($value, $propertyPath);
+    }
+
+    /**
+     * Check if a built-in type is valid
+     * @param string $type the type to check
+     * @param mixed $value the value to check
+     * @param string $path the path to the data in the base data (used for error messages)
+     * @return bool if the type is valid
+     * @throws UnsupportedTypeException if the type of the property is unsupported
+     */
+    protected function isBuiltInTypeValid(string $type, mixed $value, string $path): bool
+    {
+        return match ($type) {
+            "bool" => is_bool($value),
+            "int" => is_int($value),
+            "float" => is_float($value) || is_int($value),
+            "string" => is_string($value),
+            "mixed" => true,
+            "array" => is_array($value),
+            "object" => is_object($value),
+            "false" => $value === false,
+            "true" => $value === true,
+            default => throw new UnsupportedTypeException($path, $type),
+        };
     }
 }

tests/src/ArrayDeserializerAccessor.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Aternos\Serializer\Test\Src;
+
+use Aternos\Serializer\ArrayDeserializer;
+
+class ArrayDeserializerAccessor extends ArrayDeserializer
+{
+    public function isBuiltInTypeValid(string $type, mixed $value, string $path): bool
+    {
+        return parent::isBuiltInTypeValid($type, $value, $path);
+    }
+}

tests/tests/DeserializerTest.php

@@ -7,6 +7,7 @@
 use Aternos\Serializer\Exceptions\MissingPropertyException;
 use Aternos\Serializer\Exceptions\UnsupportedTypeException;
 use Aternos\Serializer\Serialize;
+use Aternos\Serializer\Test\Src\ArrayDeserializerAccessor;
 use Aternos\Serializer\Test\Src\ArrayTests;
 use Aternos\Serializer\Test\Src\BuiltInTypeTestClass;
 use Aternos\Serializer\Test\Src\DefaultValueTestClass;
@@ -471,4 +472,12 @@ public function testDeserializeTypedArrayPreservesKeys(): void
         $expected->int = 1;
         $this->assertEquals(["test" => $expected], $testClass->typedArray);
     }
+
+    public function testUnknownBuiltInType(): void
+    {
+        $deserializer = new ArrayDeserializerAccessor(TestClass::class);
+        $this->expectException(UnsupportedTypeException::class);
+        $this->expectExceptionMessage("Unsupported type 'not-a-real-type' for property '.name'");
+        $deserializer->isBuiltInTypeValid("not-a-real-type", "test", ".name");
+    }
 }