Skip to content

Commit 177b647

Browse files
committed
perf fix; cache GetEngineVersion result at serialization time
1 parent e28d709 commit 177b647

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

UAssetAPI/UAsset.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1739,6 +1739,7 @@ public override MemoryStream WriteData()
17391739
finally
17401740
{
17411741
isSerializationTime = false;
1742+
GetEngineVersion(); // update dirty state
17421743
}
17431744
return stre;
17441745
}

UAssetAPI/UnrealPackage.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -566,12 +566,26 @@ public static EngineVersion GetEngineVersion(ObjectVersion objectVersion, Object
566566
return EngineVersion.UNKNOWN;
567567
}
568568

569+
private EngineVersion _cachedEngineVersion = EngineVersion.UNKNOWN;
570+
private bool _cachedEngineVersionDirty = true; // used only at serialization time to determine if we need to re-evaluate this
571+
569572
/// <summary>
570573
/// Estimates the retail version of the Unreal Engine based on the object and custom versions.
571574
/// </summary>
572575
/// <returns>The estimated retail version of the Unreal Engine.</returns>
573576
public EngineVersion GetEngineVersion()
574577
{
578+
if (isSerializationTime)
579+
{
580+
if (_cachedEngineVersionDirty)
581+
{
582+
_cachedEngineVersionDirty = false;
583+
_cachedEngineVersion = UnrealPackage.GetEngineVersion(ObjectVersion, ObjectVersionUE5, CustomVersionContainer);
584+
}
585+
return _cachedEngineVersion;
586+
}
587+
588+
_cachedEngineVersionDirty = true;
575589
return UnrealPackage.GetEngineVersion(ObjectVersion, ObjectVersionUE5, CustomVersionContainer);
576590
}
577591

0 commit comments

Comments
 (0)