Add virtual dtor for ideep context (pytorch#10059)

Yinghai Lu · facebook-github-bot · commit e04f8bbfa6d6 · 2018-07-31T15:27:02.000-07:00
Summary: Pull Request resolved: pytorch#10059 Without virtual dtor, it could induce incorrect sized deallocation, messing up the memory. And unfortunately, sized deallocation cannot be detected by ASAN, yet. Reviewed By: jerryzh168 Differential Revision: D9080526 fbshipit-source-id: c136cf653134e75b074326be2bc03627da42446f
diff --git a/caffe2/ideep/utils/ideep_context.h b/caffe2/ideep/utils/ideep_context.h
@@ -21,7 +21,7 @@ class IDEEPContext final : public BaseContext {
     CAFFE_ENFORCE_EQ(option.device_type(), IDEEP);
   }
 
-  ~IDEEPContext() noexcept {}
+  ~IDEEPContext() noexcept override {}
 
   BaseStaticContext* GetStaticContext() const override {
     return GetIDEEPStaticContext();

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class IDEEPContext final : public BaseContext {`
`21`	`21`	`CAFFE_ENFORCE_EQ(option.device_type(), IDEEP);`
`22`	`22`	`}`
`23`	`23`
`24`		`- ~IDEEPContext() noexcept {}`
	`24`	`+ ~IDEEPContext() noexcept override {}`
`25`	`25`
`26`	`26`	`BaseStaticContext* GetStaticContext() const override {`
`27`	`27`	`return GetIDEEPStaticContext();`