Skip to content

Conversation

@anessi
Copy link

@anessi anessi commented Jun 30, 2025

Description

Adds support for decimal min and max, see #326

Fixes the issue in #427

Related issue(s)
Fixes #326

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Tenischev
Copy link
Member

@anessi Thank you for the contribution!
Could you please cover this with test? Feel free to modify for example additional-type-formats.yml or add new API mock

@Tenischev Tenischev self-assigned this Jul 1, 2025
Signed-off-by: anessi <16045045+anessi@users.noreply.github.com>
@anessi
Copy link
Author

anessi commented Jul 8, 2025

@Tenischev : I added a test and also checked that the generated Java code compiles.

The testing behaviour is quite strange to me as I sometimes have to run the test multiple times, that it succeeds. This gets fixed by adding --runInBand --no-cache, however it seems there are issues with the line breaks in the template snapshots.
I'm executing docker run --rm -it -v "$PWD":/app -w /app node:24 bash from the repository root to run it in an isolated environment and then run npm install and npm test -- --runInBand --no-cache -u.

I'm not a JS developer, so maybe I'm doing something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support decimal min and max

2 participants