Skip to content

add os::windows::symlink_{dir,file} #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from Nov 20, 2019
Merged

add os::windows::symlink_{dir,file} #552

merged 2 commits into from Nov 20, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 18, 2019

No description provided.

yoshuawuyts
yoshuawuyts requested changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very excited about this patch. We never quite got around to finishing up the os submodule, and this is greatly welcomed!

Left a note on how to fix failing CI; but otherwise this is good!

@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Nov 20, 2019
@yoshuawuyts
Copy link
Contributor

Oh, one last thing. We should probably mark these APIs as "unstable". But I can do that in a follow-up PR. Thanks heaps!

@yoshuawuyts yoshuawuyts merged commit 2ca03ca into async-rs:master Nov 20, 2019
@yoshuawuyts yoshuawuyts mentioned this pull request Nov 20, 2019
Merged
@ghost ghost deleted the win_symlink branch November 21, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yoshuawuyts