Add an accept header in JSON request to help 3rd party services like localstack (#1721)

jderusse · web-flow · commit a0c4617ddea2 · 2024-06-05T21:12:02.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
+
 ## 2.1.0
 
 ### Added
diff --git a/src/Input/ChangeMessageVisibilityBatchRequest.php b/src/Input/ChangeMessageVisibilityBatchRequest.php
@@ -78,6 +78,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.ChangeMessageVisibilityBatch',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/ChangeMessageVisibilityRequest.php b/src/Input/ChangeMessageVisibilityRequest.php
@@ -92,6 +92,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.ChangeMessageVisibility',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/CreateQueueRequest.php b/src/Input/CreateQueueRequest.php
@@ -247,6 +247,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.CreateQueue',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/DeleteMessageBatchRequest.php b/src/Input/DeleteMessageBatchRequest.php
@@ -78,6 +78,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.DeleteMessageBatch',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/DeleteMessageRequest.php b/src/Input/DeleteMessageRequest.php
@@ -74,6 +74,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.DeleteMessage',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/DeleteQueueRequest.php b/src/Input/DeleteQueueRequest.php
@@ -57,6 +57,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.DeleteQueue',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetQueueAttributesRequest.php b/src/Input/GetQueueAttributesRequest.php
@@ -201,6 +201,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.GetQueueAttributes',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/GetQueueUrlRequest.php b/src/Input/GetQueueUrlRequest.php
@@ -73,6 +73,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.GetQueueUrl',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/ListQueuesRequest.php b/src/Input/ListQueuesRequest.php
@@ -86,6 +86,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.ListQueues',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/PurgeQueueRequest.php b/src/Input/PurgeQueueRequest.php
@@ -57,6 +57,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.PurgeQueue',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/ReceiveMessageRequest.php b/src/Input/ReceiveMessageRequest.php
@@ -256,6 +256,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.ReceiveMessage',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/SendMessageBatchRequest.php b/src/Input/SendMessageBatchRequest.php
@@ -78,6 +78,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.SendMessageBatch',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/src/Input/SendMessageRequest.php b/src/Input/SendMessageRequest.php
@@ -251,6 +251,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.0',
             'X-Amz-Target' => 'AmazonSQS.SendMessage',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query
diff --git a/tests/Unit/Input/ChangeMessageVisibilityBatchRequestTest.php b/tests/Unit/Input/ChangeMessageVisibilityBatchRequestTest.php
@@ -24,6 +24,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.ChangeMessageVisibilityBatch
+            Accept: application/json
 
             {
                 "QueueUrl": "queueUrl",
diff --git a/tests/Unit/Input/ChangeMessageVisibilityRequestTest.php b/tests/Unit/Input/ChangeMessageVisibilityRequestTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.ChangeMessageVisibility
+            Accept: application/json
 
             {
                 "QueueUrl": "queueUrl",
diff --git a/tests/Unit/Input/CreateQueueRequestTest.php b/tests/Unit/Input/CreateQueueRequestTest.php
@@ -20,6 +20,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.CreateQueue
+            Accept: application/json
 
             {
                 "QueueName":"MyQueue",
diff --git a/tests/Unit/Input/DeleteMessageBatchRequestTest.php b/tests/Unit/Input/DeleteMessageBatchRequestTest.php
@@ -23,6 +23,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.DeleteMessageBatch
+            Accept: application/json
 
             {
                 "QueueUrl": "queueUrl",
diff --git a/tests/Unit/Input/DeleteMessageRequestTest.php b/tests/Unit/Input/DeleteMessageRequestTest.php
@@ -19,6 +19,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.DeleteMessage
+            Accept: application/json
 
             {
                 "QueueUrl": "queueUrl",
diff --git a/tests/Unit/Input/DeleteQueueRequestTest.php b/tests/Unit/Input/DeleteQueueRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.DeleteQueue
+            Accept: application/json
 
             {
                 "QueueUrl":"queueUrl"
diff --git a/tests/Unit/Input/GetQueueAttributesRequestTest.php b/tests/Unit/Input/GetQueueAttributesRequestTest.php
@@ -19,6 +19,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.GetQueueAttributes
+            Accept: application/json
 
             {
                 "QueueUrl": "queueUrl",
diff --git a/tests/Unit/Input/GetQueueUrlRequestTest.php b/tests/Unit/Input/GetQueueUrlRequestTest.php
@@ -19,6 +19,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.GetQueueUrl
+            Accept: application/json
 
             {
                 "QueueName": "MyQueue",
diff --git a/tests/Unit/Input/ListQueuesRequestTest.php b/tests/Unit/Input/ListQueuesRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.ListQueues
+            Accept: application/json
 
             {
                 "QueueNamePrefix": "M"
diff --git a/tests/Unit/Input/PurgeQueueRequestTest.php b/tests/Unit/Input/PurgeQueueRequestTest.php
@@ -18,6 +18,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.PurgeQueue
+            Accept: application/json
 
             {
                 "QueueUrl": "queueUrl"
diff --git a/tests/Unit/Input/ReceiveMessageRequestTest.php b/tests/Unit/Input/ReceiveMessageRequestTest.php
@@ -25,6 +25,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.ReceiveMessage
+            Accept: application/json
 
             {
                 "QueueUrl": "queueUrl",
diff --git a/tests/Unit/Input/SendMessageBatchRequestTest.php b/tests/Unit/Input/SendMessageBatchRequestTest.php
@@ -31,6 +31,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.SendMessageBatch
+            Accept: application/json
 
             {
                 "QueueUrl": "queueUrl",
diff --git a/tests/Unit/Input/SendMessageRequestTest.php b/tests/Unit/Input/SendMessageRequestTest.php
@@ -33,6 +33,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.0
             x-amz-target: AmazonSQS.SendMessage
+            Accept: application/json
 
             {
                 "QueueUrl": "queueUrl",

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ public function testRequest(): void`
`24`	`24`	`POST / HTTP/1.0`
`25`	`25`	`Content-Type: application/x-amz-json-1.0`
`26`	`26`	`x-amz-target: AmazonSQS.ChangeMessageVisibilityBatch`
	`27`	`+ Accept: application/json`
`27`	`28`
`28`	`29`	`{`
`29`	`30`	`"QueueUrl": "queueUrl",`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ public function testRequest(): void`
`20`	`20`	`POST / HTTP/1.0`
`21`	`21`	`Content-Type: application/x-amz-json-1.0`
`22`	`22`	`x-amz-target: AmazonSQS.ChangeMessageVisibility`
	`23`	`+ Accept: application/json`
`23`	`24`
`24`	`25`	`{`
`25`	`26`	`"QueueUrl": "queueUrl",`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ public function testRequest(): void`
`23`	`23`	`POST / HTTP/1.0`
`24`	`24`	`Content-Type: application/x-amz-json-1.0`
`25`	`25`	`x-amz-target: AmazonSQS.DeleteMessageBatch`
	`26`	`+ Accept: application/json`
`26`	`27`
`27`	`28`	`{`
`28`	`29`	`"QueueUrl": "queueUrl",`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ public function testRequest(): void`
`19`	`19`	`POST / HTTP/1.0`
`20`	`20`	`Content-Type: application/x-amz-json-1.0`
`21`	`21`	`x-amz-target: AmazonSQS.DeleteMessage`
	`22`	`+ Accept: application/json`
`22`	`23`
`23`	`24`	`{`
`24`	`25`	`"QueueUrl": "queueUrl",`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@ public function testRequest(): void`
`18`	`18`	`POST / HTTP/1.0`
`19`	`19`	`Content-Type: application/x-amz-json-1.0`
`20`	`20`	`x-amz-target: AmazonSQS.DeleteQueue`
	`21`	`+ Accept: application/json`
`21`	`22`
`22`	`23`	`{`
`23`	`24`	`"QueueUrl":"queueUrl"`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ public function testRequest(): void`
`25`	`25`	`POST / HTTP/1.0`
`26`	`26`	`Content-Type: application/x-amz-json-1.0`
`27`	`27`	`x-amz-target: AmazonSQS.ReceiveMessage`
	`28`	`+ Accept: application/json`
`28`	`29`
`29`	`30`	`{`
`30`	`31`	`"QueueUrl": "queueUrl",`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public function testRequest(): void`
`31`	`31`	`POST / HTTP/1.0`
`32`	`32`	`Content-Type: application/x-amz-json-1.0`
`33`	`33`	`x-amz-target: AmazonSQS.SendMessageBatch`
	`34`	`+ Accept: application/json`
`34`	`35`
`35`	`36`	`{`
`36`	`37`	`"QueueUrl": "queueUrl",`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ public function testRequest(): void`
`33`	`33`	`POST / HTTP/1.0`
`34`	`34`	`Content-Type: application/x-amz-json-1.0`
`35`	`35`	`x-amz-target: AmazonSQS.SendMessage`
	`36`	`+ Accept: application/json`
`36`	`37`
`37`	`38`	`{`
`38`	`39`	`"QueueUrl": "queueUrl",`