Skip to content

Commit 3a11152

Browse files
authored
Improve the makefile setup (#1597)
* Remove containers when stopping them This ensures that starting the setup again picks up the new version of the image during the next run. * Clean docker setups in components The components should be pulling the images they launch and not a different tag. And they should not try to start the shared localstack container when the image they use is not localstack. Instead, the should check for the shared container created by the root Makefile * Clean all docker images of the root Makefile * Change the root Makefile to be consistent with services Instead of having `make stop-docker` triggering the `clean` command (which also triggers the cleaning of sub-services), it is now `clean` which depends on `stop-docker` of the root repo. This brings consistency with initialization commands. We now have a symmetry between `initialize`/`clean` and `start-docker`/`stop-docker`.
1 parent b2f9a9d commit 3a11152

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ test: initialize
1212
clean: stop-docker
1313
stop-docker:
1414
docker stop async_aws_sqs || true
15+
docker rm async_aws_sqs || true

0 commit comments

Comments
 (0)