Add an accept header in JSON request to help 3rd party services like localstack (#1721)

Author: jderusse

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
+
 ## 1.4.0
 
 ### Added

src/Input/CreateAliasRequest.php

@@ -99,6 +99,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'TrentService.CreateAlias',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

src/Input/CreateKeyRequest.php

@@ -423,6 +423,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'TrentService.CreateKey',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

src/Input/DecryptRequest.php

@@ -221,6 +221,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'TrentService.Decrypt',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

src/Input/EncryptRequest.php

@@ -190,6 +190,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'TrentService.Encrypt',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

src/Input/GenerateDataKeyRequest.php

@@ -220,6 +220,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'TrentService.GenerateDataKey',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

src/Input/ListAliasesRequest.php

@@ -99,6 +99,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'TrentService.ListAliases',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

src/Input/SignRequest.php

@@ -202,6 +202,7 @@ public function request(): Request
         $headers = [
             'Content-Type' => 'application/x-amz-json-1.1',
             'X-Amz-Target' => 'TrentService.Sign',
+            'Accept' => 'application/json',
         ];
 
         // Prepare query

tests/Unit/Input/CreateAliasRequestTest.php

@@ -19,6 +19,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: TrentService.CreateAlias
+            Accept: application/json
 
             {
                 "AliasName": "alias\\/ExampleAlias",

tests/Unit/Input/CreateKeyRequestTest.php

@@ -30,6 +30,7 @@ public function testRequest(): void
             POST / HTTP/1.0
             Content-Type: application/x-amz-json-1.1
             x-amz-target: TrentService.CreateKey
+            Accept: application/json
 
             {
               "Description": "My key",