Use int as the PHP representation of long fields in generated code (#1471)

* Use int as the PHP representation of long fields in generated code

* Add changelog entries for signature changes affecting strict types

* Remove generator hacks needed for endpoint shapes to force the type

Now that long fields are always defined as integer, we don't need such
hacks anymore

Author: stof

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## NOT RELEASED
 
+### BC-BREAK
+
+- The type for `\AsyncAws\Iot\Input\DeleteThingGroupRequest::getExpectedVersion` and `\AsyncAws\Iot\Input\DeleteThingGroupRequest::setExpectedVersion` uses `int` instead of `string` to reflect the AWS type.
+- The type for `\AsyncAws\Iot\Input\DeleteThingRequest::getExpectedVersion` and `\AsyncAws\Iot\Input\DeleteThingGroupRequest::setExpectedVersion` uses `int` instead of `string` to reflect the AWS type.
+- The return type for `\AsyncAws\Iot\ValueObject\ThingAttribute::getVersion` uses `int` instead of `string` to reflect the AWS type.
+
 ## 1.0.0
 
 ### Added

src/Input/DeleteThingGroupRequest.php

@@ -21,14 +21,14 @@ final class DeleteThingGroupRequest extends Input
     /**
      * The expected version of the thing group to delete.
      *
-     * @var string|null
+     * @var int|null
      */
     private $expectedVersion;
 
     /**
      * @param array{
      *   thingGroupName?: string,
-     *   expectedVersion?: string,
+     *   expectedVersion?: int,
      *   '@region'?: string|null,
      * } $input
      */
@@ -42,7 +42,7 @@ public function __construct(array $input = [])
     /**
      * @param array{
      *   thingGroupName?: string,
-     *   expectedVersion?: string,
+     *   expectedVersion?: int,
      *   '@region'?: string|null,
      * }|DeleteThingGroupRequest $input
      */
@@ -51,7 +51,7 @@ public static function create($input): self
         return $input instanceof self ? $input : new self($input);
     }
 
-    public function getExpectedVersion(): ?string
+    public function getExpectedVersion(): ?int
     {
         return $this->expectedVersion;
     }
@@ -72,7 +72,7 @@ public function request(): Request
         // Prepare query
         $query = [];
         if (null !== $this->expectedVersion) {
-            $query['expectedVersion'] = $this->expectedVersion;
+            $query['expectedVersion'] = (string) $this->expectedVersion;
         }
 
         // Prepare URI
@@ -90,7 +90,7 @@ public function request(): Request
         return new Request('DELETE', $uriString, $query, $headers, StreamFactory::create($body));
     }
 
-    public function setExpectedVersion(?string $value): self
+    public function setExpectedVersion(?int $value): self
     {
         $this->expectedVersion = $value;
 

src/Input/DeleteThingRequest.php

@@ -26,14 +26,14 @@ final class DeleteThingRequest extends Input
      * the expected version specified in the request, the `DeleteThing` request is rejected with a
      * `VersionConflictException`.
      *
-     * @var string|null
+     * @var int|null
      */
     private $expectedVersion;
 
     /**
      * @param array{
      *   thingName?: string,
-     *   expectedVersion?: string,
+     *   expectedVersion?: int,
      *   '@region'?: string|null,
      * } $input
      */
@@ -47,7 +47,7 @@ public function __construct(array $input = [])
     /**
      * @param array{
      *   thingName?: string,
-     *   expectedVersion?: string,
+     *   expectedVersion?: int,
      *   '@region'?: string|null,
      * }|DeleteThingRequest $input
      */
@@ -56,7 +56,7 @@ public static function create($input): self
         return $input instanceof self ? $input : new self($input);
     }
 
-    public function getExpectedVersion(): ?string
+    public function getExpectedVersion(): ?int
     {
         return $this->expectedVersion;
     }
@@ -77,7 +77,7 @@ public function request(): Request
         // Prepare query
         $query = [];
         if (null !== $this->expectedVersion) {
-            $query['expectedVersion'] = $this->expectedVersion;
+            $query['expectedVersion'] = (string) $this->expectedVersion;
         }
 
         // Prepare URI
@@ -95,7 +95,7 @@ public function request(): Request
         return new Request('DELETE', $uriString, $query, $headers, StreamFactory::create($body));
     }
 
-    public function setExpectedVersion(?string $value): self
+    public function setExpectedVersion(?int $value): self
     {
         $this->expectedVersion = $value;
 

src/IotClient.php

@@ -221,7 +221,7 @@ public function createThingType($input): CreateThingTypeResponse
      *
      * @param array{
      *   thingName: string,
-     *   expectedVersion?: string,
+     *   expectedVersion?: int,
      *   '@region'?: string|null,
      * }|DeleteThingRequest $input
      *
@@ -261,7 +261,7 @@ public function deleteThing($input): DeleteThingResponse
      *
      * @param array{
      *   thingGroupName: string,
-     *   expectedVersion?: string,
+     *   expectedVersion?: int,
      *   '@region'?: string|null,
      * }|DeleteThingGroupRequest $input
      *

src/Result/ListThingsResponse.php

@@ -115,7 +115,7 @@ private function populateResultThingAttribute(array $json): ThingAttribute
             'thingTypeName' => isset($json['thingTypeName']) ? (string) $json['thingTypeName'] : null,
             'thingArn' => isset($json['thingArn']) ? (string) $json['thingArn'] : null,
             'attributes' => !isset($json['attributes']) ? null : $this->populateResultAttributes($json['attributes']),
-            'version' => isset($json['version']) ? (string) $json['version'] : null,
+            'version' => isset($json['version']) ? (int) $json['version'] : null,
         ]);
     }
 

src/ValueObject/ThingAttribute.php

@@ -38,7 +38,7 @@ final class ThingAttribute
      *   thingTypeName?: null|string,
      *   thingArn?: null|string,
      *   attributes?: null|array<string, string>,
-     *   version?: null|string,
+     *   version?: null|int,
      * } $input
      */
     public function __construct(array $input)
@@ -56,7 +56,7 @@ public function __construct(array $input)
      *   thingTypeName?: null|string,
      *   thingArn?: null|string,
      *   attributes?: null|array<string, string>,
-     *   version?: null|string,
+     *   version?: null|int,
      * }|ThingAttribute $input
      */
     public static function create($input): self
@@ -87,7 +87,7 @@ public function getThingTypeName(): ?string
         return $this->thingTypeName;
     }
 
-    public function getVersion(): ?string
+    public function getVersion(): ?int
     {
         return $this->version;
     }