This repository was archived by the owner on Aug 9, 2023. It is now read-only.
Commit 48f9cb2
authored
Update test to show on issue in code (#752)
* Update test to show on issue in code
This commit updates the test for S3FilesystemV1 to point out a issue in how the code works when trying to access a url for a S3 object using the Filesystem adapter in Laravel.
I have code like this
Storage::disk('public')->url($filename);
where the disk public is configured with:
'driver' => 'async-aws-s3',
The issue that I see is that \AsyncAws\Illuminate\Filesystem\AsyncAwsFilesystemAdapter::url is accessing the S3FilesystemV1 and trying to call getClient on it which does not exists in the version required by this (0.3.3).
It is added and tagged in 0.4.0.
* Fix issue with missing S3FilesystemV1 getClient
Require version ^0.4.0 of async-aws/flysystem-s3 to get a version where \AsyncAws\Flysystem\S3\S3FilesystemV1::getClient exist.
This is used in \AsyncAws\Illuminate\Filesystem\AsyncAwsFilesystemAdapter::url1 parent 0ad5578 commit 48f9cb2
2 files changed
+2
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | | - | |
48 | | - | |
| 46 | + | |
49 | 47 | | |
50 | 48 | | |
51 | 49 | | |
| |||
0 commit comments