Drop support for PHP lower than 8.2 (#1967)

* Drop support for PHP lower than 8.2

* Remove dead code related to old PHP versions

* Regenerate the Psalm baseline

Author: stof

.github/workflows/ci.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       max-parallel: 10
       matrix:
-        php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
+        php: ['8.2', '8.3', '8.4', '8.5']
 
     steps:
       - name: Set up PHP

CHANGELOG.md

@@ -6,6 +6,10 @@
 
 - AWS api-change: Added `us-isob-west-1` region
 
+### Dependency bumped
+
+- Drop support for PHP versions lower than 8.2
+
 ### Changed
 
 - Apply new CodingStandard from latest php-cs-fixer.

composer.json

@@ -11,7 +11,7 @@
         "sts"
     ],
     "require": {
-        "php": "^7.2.5 || ^8.0",
+        "php": "^8.2",
         "ext-hash": "*",
         "ext-json": "*",
         "ext-simplexml": "*",

src/Credentials/InstanceProvider.php

@@ -119,17 +119,12 @@ private function toArray(ResponseInterface $response): array
         }
 
         try {
-            $content = json_decode($content, true, 512, \JSON_BIGINT_AS_STRING | (\PHP_VERSION_ID >= 70300 ? \JSON_THROW_ON_ERROR : 0));
+            $content = json_decode($content, true, 512, \JSON_BIGINT_AS_STRING | \JSON_THROW_ON_ERROR);
         } catch (\JsonException $e) {
             /** @psalm-suppress all */
             throw new JsonException(\sprintf('%s for "%s".', $e->getMessage(), $response->getInfo('url')), $e->getCode());
         }
 
-        if (\PHP_VERSION_ID < 70300 && \JSON_ERROR_NONE !== json_last_error()) {
-            /** @psalm-suppress InvalidArgument */
-            throw new JsonException(\sprintf('%s for "%s".', json_last_error_msg(), $response->getInfo('url')), json_last_error());
-        }
-
         if (!\is_array($content)) {
             /** @psalm-suppress InvalidArgument */
             throw new JsonException(\sprintf('JSON content was expected to decode to an array, %s returned for "%s".', \gettype($content), $response->getInfo('url')));

src/Credentials/SsoTokenProvider.php

@@ -150,7 +150,7 @@ private function loadSsoToken(string $sessionName): ?array
                 $content,
                 true,
                 512,
-                \JSON_BIGINT_AS_STRING | (\PHP_VERSION_ID >= 70300 ? \JSON_THROW_ON_ERROR : 0)
+                \JSON_BIGINT_AS_STRING | \JSON_THROW_ON_ERROR
             );
         } catch (\JsonException $e) {
             $this->logger->warning(

src/Test/ResultMockFactory.php

@@ -84,9 +84,6 @@ public static function create(string $class, array $data = [])
         // Make sure the Result is initialized
         $reflectionClass = new \ReflectionClass(Result::class);
         $initializedProperty = $reflectionClass->getProperty('initialized');
-        if (\PHP_VERSION_ID < 80100) {
-            $initializedProperty->setAccessible(true);
-        }
 
         /** @psalm-var \ReflectionClass<T> $reflectionClass */
         $reflectionClass = new \ReflectionClass($class);
@@ -118,9 +115,6 @@ public static function create(string $class, array $data = [])
                     $property = $reflectionClass->getProperty($propertyName);
                 }
             }
-            if (\PHP_VERSION_ID < 80100) {
-                $property->setAccessible(true);
-            }
             $property->setValue($object, $propertyValue);
         }
 
@@ -155,14 +149,8 @@ public static function waiter(string $class, string $finalState)
 
         $reflectionClass = new \ReflectionClass(Waiter::class);
         $propertyResponse = $reflectionClass->getProperty('response');
-        if (\PHP_VERSION_ID < 80100) {
-            $propertyResponse->setAccessible(true);
-        }
 
         $propertyState = $reflectionClass->getProperty('finalState');
-        if (\PHP_VERSION_ID < 80100) {
-            $propertyState->setAccessible(true);
-        }
 
         /** @psalm-var \ReflectionClass<T> $reflectionClass */
         $reflectionClass = new \ReflectionClass($class);
@@ -225,9 +213,6 @@ private static function addUndefinedProperties(\ReflectionClass $reflectionClass
             }
 
             if (null !== $propertyValue) {
-                if (\PHP_VERSION_ID < 80100) {
-                    $property->setAccessible(true);
-                }
                 $property->setValue($object, $propertyValue);
             }
         }
@@ -270,18 +255,12 @@ private static function addPropertiesOnResult(\ReflectionClass $reflectionClass,
         if (class_exists($awsClientClass)) {
             $awsClientMock = (new \ReflectionClass($awsClientClass))->newInstanceWithoutConstructor();
             $property = $reflectionClass->getProperty('awsClient');
-            if (\PHP_VERSION_ID < 80100) {
-                $property->setAccessible(true);
-            }
             $property->setValue($object, $awsClientMock);
         }
 
         if (class_exists($inputClass)) {
             $inputMock = (new \ReflectionClass($inputClass))->newInstanceWithoutConstructor();
             $property = $reflectionClass->getProperty('input');
-            if (\PHP_VERSION_ID < 80100) {
-                $property->setAccessible(true);
-            }
             $property->setValue($object, $inputMock);
         }
     }
@@ -292,21 +271,12 @@ private static function getResponseObject(): Response
         $response = $reflectionClass->newInstanceWithoutConstructor();
 
         $property = $reflectionClass->getProperty('resolveResult');
-        if (\PHP_VERSION_ID < 80100) {
-            $property->setAccessible(true);
-        }
         $property->setValue($response, true);
 
         $property = $reflectionClass->getProperty('bodyDownloaded');
-        if (\PHP_VERSION_ID < 80100) {
-            $property->setAccessible(true);
-        }
         $property->setValue($response, true);
 
         $property = $reflectionClass->getProperty('httpResponse');
-        if (\PHP_VERSION_ID < 80100) {
-            $property->setAccessible(true);
-        }
         $property->setValue($response, new SimpleMockedResponse());
 
         return $response;