parent and child type fix + removing payload initialization

Author: Pushkar-Bhuse

forte/data/data_store.py

@@ -890,7 +890,7 @@ def get_datastore_attr_idx(self, type_name: str, attr: str) -> int:
 
         Args:
             type_name (str): The fully qualified type name of the entry.
-            attr (str): The name of the attribute whose index beeds to be fetched.
+            attr (str): The name of the attribute whose index needs to be fetched.
 
         Returns:
             An integer representing the attributes position in the Data
@@ -917,7 +917,7 @@ def initialize_and_validate_entry(
         `member_type` is converted from an object to `str`.
 
         Args:
-            entry (list): The initial version of the dtaa store entry
+            entry (list): The initial version of the data store entry
                 whose values need to be validated.
 
         Returns:

forte/data/extractors/relation_extractor.py

@@ -69,14 +69,14 @@ def initialize(self, config: Union[Dict, Config]):
                     "`entry_class` to this extractor " "must be a Link tpe."
                 )
 
-            self._parent_class: Type[Annotation] = self._entry_class.ParentType
+            self._parent_class: Type[Annotation] = self._entry_class.ParentType  # type: ignore
             if not issubclass(self._parent_class, Annotation):
                 raise ProcessorConfigError(
                     f"The parent class of the provided {self.config.entry_type}"
                     " must be an Annotation."
                 )
 
-            self._child_class: Type[Annotation] = self._entry_class.ChildType
+            self._child_class: Type[Annotation] = self._entry_class.ChildType  # type: ignore
             if not issubclass(self._child_class, Annotation):
                 raise ProcessorConfigError(
                     f"The child class of the provided {self.config.entry_type}"

forte/data/ontology/core.py

@@ -21,6 +21,7 @@
 from collections.abc import MutableSequence, MutableMapping
 from dataclasses import dataclass
 from typing import (
+    Any,
     Iterable,
     Optional,
     Tuple,
@@ -500,6 +501,11 @@ def data(self, array: Union[np.ndarray, List]):
 
 
 class BaseLink(Entry, ABC):
+
+    # this type Any is needed since subclasses of this class will have new types
+    ParentType: Any = Entry
+    ChildType: Any = Entry
+
     def __init__(
         self,
         pack: ContainerType,

forte/data/ontology/top.py

@@ -93,13 +93,10 @@ class Annotation(Entry):
     end: int
     payload_idx: int
 
-    def __init__(
-        self, pack: PackType, begin: int, end: int, text_payload_idx: int = 0
-    ):
+    def __init__(self, pack: PackType, begin: int, end: int):
         self._span: Optional[Span] = None
         self.begin: int = begin
         self.end: int = end
-        self.payload_idx: int = text_payload_idx
         super().__init__(pack)
 
     def __getstate__(self):
@@ -609,14 +606,11 @@ class AudioAnnotation(Entry):
     end: int
     payload_idx: int
 
-    def __init__(
-        self, pack: PackType, begin: int, end: int, audio_payload_idx: int = 0
-    ):
+    def __init__(self, pack: PackType, begin: int, end: int):
 
         self._span: Optional[Span] = None
         self.begin: int = begin
         self.end: int = end
-        self.payload_idx: int = audio_payload_idx
         super().__init__(pack)
 
     @property