Skip to content
This repository was archived by the owner on Jun 5, 2024. It is now read-only.

TST: Use Actions, update test matrix #38

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Nov 12, 2020

@pllim pllim requested review from saimn and astrofrog November 12, 2020 19:00
matrix:
include:
- name: Python 3.6 and pytest 4.6 (Linux)
os: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is not used. On doctestplus / remotedata I did not put a name because the os/python_version/toxenv combination seems clear enough. If there is a preference for a readable name, that's fine by me, but it should then probably be used to name the build (I guess name: ${{ matrix.name }} near runs-on) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is used for display on the left navbar. But if you feel strongly about them, I can remove. I copy pasted from the Travis setup.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemme know. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are fine, it's just that it would be better to be consistent between repos.
For me the name does not add much information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of moving this forward, I removed the names. See https://github.com/pllim/pytest-openfiles/actions/runs/360370589

Copy link
Contributor

@saimn saimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pllim , let's move forward and migrate another repo :)

@saimn saimn merged commit 236bc55 into astropy:master Nov 12, 2020
@pllim pllim deleted the last-actions-hero branch November 12, 2020 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants