[DISCUSS] remote-exec support #1881
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a rough skeleton of what it would look like to support remote execution.
Before I go further I want to open this up for some review feedback to make sure this is a direction we want to pursue.
the approach was to define a new
remote-docker-compose.yaml
and aremote-exec
package that basically re-uses most of the airflow packages docker utilities forastro dev start|stop|kill
to provide a similar experience for running remote agents locally.Purpose
Currently, the purpose of this PR is to make a demo / POC for discussion and to assess the value of further investing in this feature.
Going forward with this would increase our maintenance surface area and here is a decent amount more work required here just to get to MVP, and there are some clear next steps to make this really nice for users described in #1880.
I personally think this would make it much smoother to register astro-agents from non-kubernetes environments.
Status:
this almost works but needs to do something to side-load the astro-agent stuff in as right now it just reads the runtime image from the remote deployment in core API. @ianbuss @neel-astro curious what you would recommend for this. I imagine we could develop a mechanism to dynamically pull the latest agent release and mount it into the proper path.
TODOs
astro dev *
commands which is midleading. We should refactor to properly pull the docker / compose logic out into a common package and have theairflow
andremote-exec
handle these error messages.Try again or use the --wait flag to increase the time out```
🎟 Issue(s)
Related #1880
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft