Use floating tag for init of Airflow 3 Dockerfile #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremybeard
requested review from
neel-astro,
kushalmalani and
lzdanski
as code owners
jeremybeard
commented
May 12, 2025
There was a problem hiding this comment.
Dropped this file because it seems to be interacting with Docker Hub and so can unreliably fail, and is anyway not really unit testing any of the CLI logic.
jeremybeard
commented
May 12, 2025
| err := airflowInit(cmd, args) | ||
| s.NoError(err) | ||
|
|
||
| b, _ := os.ReadFile(filepath.Join(s.tempDir, "Dockerfile")) |
There was a problem hiding this comment.
More non-unit unit testing, this time these fail because now that Airflow 3 is released the default Dockerfile does not contain this string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the
astro dev initDockerfile for Airflow 3 to use the minor version floating tag instead of the exact patch tag (e.g.3.0instead of3.0-1). This will mean that new patches of a minor version will automatically be picked up by the project.📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft