Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect color settings for log messages #11604

Merged
merged 1 commit into from
Feb 18, 2025
Merged

respect color settings for log messages #11604

merged 1 commit into from
Feb 18, 2025

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Feb 18, 2025

fixes #11560

@Gankra Gankra added bug Something isn't working tracing Verbose output and debugging labels Feb 18, 2025
@Gankra
Copy link
Contributor Author

Gankra commented Feb 18, 2025 •
edited
Loading

Using anstream inside tracing would be great, I ran into trait typing problems last time I tried that.

I have a feeling I attempted the exact same fix konsti did and ran into exactly this issue and then I realized I was solving the problem at the wrong abstraction layer and it all worked totally fine.

@Gankra Gankra merged commit f394f72 into main Feb 18, 2025
73 checks passed
@Gankra Gankra deleted the gankra/colr branch February 18, 2025 20:39
@BrewTestBot BrewTestBot mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working tracing Verbose output and debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing color despite --color never or NO_COLOR=1 on uv python install
2 participants
@Gankra @zanieb