Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uv run - should pipe input #6529

Open
charliermarsh opened this issue Aug 23, 2024 · 6 comments · May be fixed by #8301
Open

uv run - should pipe input #6529

charliermarsh opened this issue Aug 23, 2024 · 6 comments · May be fixed by #8301
Labels
internal A refactor or improvement that is not user-facing performance Potential performance improvement

Comments

@charliermarsh
Copy link
Member

charliermarsh commented Aug 23, 2024 •
edited
Loading

See: #6481 (comment)
@charliermarsh charliermarsh self-assigned this Aug 23, 2024
@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Aug 23, 2024
@zanieb zanieb added the performance Potential performance improvement label Aug 23, 2024
@zanieb
Copy link
Member

zanieb commented Aug 23, 2024

Is this performance? I'm not sure. Memory usage at least.

@charliermarsh
Copy link
Member Author

Yeah makes sense, thanks.

@charliermarsh
Copy link
Member Author

I think we can't do this if we want to support tool.uv settings in scripts from stdin... Which we probably should? Since, in that case, we need to extract the settings before we run it.

@charliermarsh charliermarsh removed their assignment Aug 26, 2024
@zanieb
Copy link
Member

zanieb commented Aug 26, 2024

I think we'd just need to read until we finish the scripts block then stream the rest via a pipe — which is a bit more complicated but seems pretty reasonable. I don't think this is high priority until someone encounters a problem with storing the entire file in memory.

@charliermarsh
Copy link
Member Author

The scripts block can be anywhere in the file, so we'd have to read the whole thing in the negative case 😂

@zanieb
Copy link
Member

zanieb commented Aug 26, 2024

It can!? What the heck, spec.

@Aditya-PS-05 Aditya-PS-05 linked a pull request Oct 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal A refactor or improvement that is not user-facing performance Potential performance improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pipe input directly in uv run command Aditya-PS-05/uv
2 participants
@charliermarsh @zanieb