rye list: Never modify or delete the virtualenv #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
force-pushed
the
list-should-not-delete
branch
from
d94426f
to
2be437e
Compare
|
Making draft while figuring out some questions in #940. Edit: Now seems to be solved, the added test here fails before the fix and passes now. |
bluss
force-pushed
the
list-should-not-delete
branch
from
2be437e
to
6469a7d
Compare
bluss
force-pushed
the
list-should-not-delete
branch
from
6469a7d
to
04fc3ef
Compare
Add a new type so that we can have methods on uv + venv that do not create or modify the virtual environment.
bluss
force-pushed
the
list-should-not-delete
branch
from
04fc3ef
to
62d1d8c
Compare
charliermarsh
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in some situations,
rye pin <pythonversion>; rye listcould lead to rye deleting the existing virtualenv.I suggest that
rye listshould be an interrogator and never modify any project. With this change, it lists its own and non-rye virtualenvs (same behaviour as uv pip freeze) but should never create, recreate or overwrite environments (own or non-rye).Fixes #1352