Respect .python-version in Rye builds
#1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2024
charliermarsh
force-pushed
the
charlie/build
branch
from
bc631cb
to
92a66a9
Compare
charliermarsh
force-pushed
the
charlie/build
branch
from
92a66a9
to
9b837cf
Compare
|
Awesome! Seems to be working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Today,
rye builduses the bootstrapped (or "self") environment, which means built wheels reflect the version from the bootstrapped environment, rather than the user's Python preference.This PR changes
buildto instead create an ephemeral build environment based on the requested Python version (then install and runbuildin that environment).Creating and populating that ephemeral build environment is extremely fast with uv; there's virtually no overhead.
Closes #1152.
Closes #1248.
Test Plan
../rye/target/debug/rye buildfrom a directory with.python-versionof3.11.