fix verify-ssl option parsing problem #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j178
reviewed
Jul 9, 2024
| @@ -159,7 +159,7 @@ impl SourceRef { | |||
| .map(|x| x.to_string()) | |||
| .ok_or_else(|| anyhow!("expected source.url"))?; | |||
| let verify_ssl = source | |||
| .get("verify_ssl") | |||
There was a problem hiding this comment.
Should we read both verify_ssl and verify-ssl for backward compatibility?
There was a problem hiding this comment.
Thanks for pointing that out. I have fixed it.
…ward compatibility
charliermarsh
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/astral-sh/rye/blob/main/docs/guide/sources.md?plain=1#L131
The documentation refers to verify-ssl to avoid ssl verification, but during parsing, it refers to verify_ssl. This PR will allow the installation of packages from non-SSL PyPI repositories.
If the documentation needs to be corrected instead of the source code, please let me know, and I will commit the changes.