-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Parse
trait
#6235
Merged
Merged
Remove Parse
trait
#6235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
MichaReiser
force-pushed
the
remove-parse-trait
branch
from
August 1, 2023 10:40
f08981a
to
decc475
Compare
konstin
approved these changes
Aug 1, 2023
MichaReiser
force-pushed
the
remove-unused-modes
branch
from
August 1, 2023 10:56
9d65a48
to
b292a10
Compare
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinux
Windows
|
MichaReiser
force-pushed
the
remove-parse-trait
branch
from
August 1, 2023 11:40
decc475
to
4b7c836
Compare
zanieb
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
Parse
trait in favour ofparse_program
,parse_expression
andparse_suite
.The motivation for this change is that
Parse
is a lot of boilerplate and the three functions above are suffucient for almost all use cases. The few other use casesshould use
parse_suite
and then extract the node manually. This has the added benefit that it doesn't give the users the false safety that the operation cannot fail (e.g.IfStatement::parse
paniced if you passed anything other than an if statement).Test Plan
cargo test