Add GitHub CODEOWNERS file

[dhruvmanila]

Summary

Add GitHub CODEOWNERS file.

Initiating this, we can discuss and iterate further.

https://help.github.com/articles/about-codeowners/

Test Plan

Look out for review requests :)

[dhruvmanila]

Current dependencies on/for this PR:

• main
  • PR Add GitHub CODEOWNERS file #5054 👈

This comment was auto-generated by Graphite.

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      7.9±0.30ms     5.1 MB/sec    1.02      8.1±0.19ms     5.0 MB/sec
formatter/numpy/ctypeslib.py               1.01  1720.2±59.11µs     9.7 MB/sec    1.00  1711.6±33.96µs     9.7 MB/sec
formatter/numpy/globals.py                 1.00    162.5±4.82µs    18.2 MB/sec    1.05    170.7±9.30µs    17.3 MB/sec
formatter/pydantic/types.py                1.01      3.4±0.14ms     7.6 MB/sec    1.00      3.4±0.09ms     7.6 MB/sec
linter/all-rules/large/dataset.py          1.00     17.4±0.71ms     2.3 MB/sec    1.08     18.8±1.45ms     2.2 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.2±0.17ms     4.0 MB/sec    1.03      4.3±0.16ms     3.8 MB/sec
linter/all-rules/numpy/globals.py          1.01   555.0±39.79µs     5.3 MB/sec    1.00   551.7±26.03µs     5.3 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.9±0.68ms     3.2 MB/sec    1.01      8.0±0.31ms     3.2 MB/sec
linter/default-rules/large/dataset.py      1.00      8.7±0.26ms     4.7 MB/sec    1.03      8.9±0.13ms     4.6 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1892.5±71.30µs     8.8 MB/sec    1.01  1907.6±42.80µs     8.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    218.7±7.02µs    13.5 MB/sec    1.02   222.1±21.75µs    13.3 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.0±0.14ms     6.4 MB/sec    1.02      4.0±0.18ms     6.3 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00      7.7±0.11ms     5.3 MB/sec    1.05      8.1±1.13ms     5.0 MB/sec
formatter/numpy/ctypeslib.py               1.00  1564.3±21.62µs    10.6 MB/sec    1.27  1987.0±505.59µs     8.4 MB/sec
formatter/numpy/globals.py                 1.00    148.1±3.04µs    19.9 MB/sec    1.02    150.7±3.69µs    19.6 MB/sec
formatter/pydantic/types.py                1.00      3.1±0.04ms     8.1 MB/sec    1.02      3.2±0.17ms     7.9 MB/sec
linter/all-rules/large/dataset.py          1.00     16.3±0.23ms     2.5 MB/sec    1.01     16.4±0.22ms     2.5 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.1±0.05ms     4.0 MB/sec    1.00      4.1±0.06ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.01    494.7±7.55µs     6.0 MB/sec    1.00    489.0±6.94µs     6.0 MB/sec
linter/all-rules/pydantic/types.py         1.01      7.1±0.11ms     3.6 MB/sec    1.00      7.0±0.11ms     3.6 MB/sec
linter/default-rules/large/dataset.py      1.00      8.3±0.07ms     4.9 MB/sec    1.00      8.3±0.10ms     4.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1738.3±20.63µs     9.6 MB/sec    1.01  1758.9±25.22µs     9.5 MB/sec
linter/default-rules/numpy/globals.py      1.00   198.7±21.64µs    14.9 MB/sec    1.02   202.5±10.55µs    14.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.05ms     6.8 MB/sec    1.00      3.7±0.07ms     6.8 MB/sec

[charliermarsh]

What's the process by which this is kept up-to-date? (E.g., if we add new directories, or rename, or remove?)

[dhruvmanila]

I'm seeing a message on top of the file saying "This CODEOWNERS file is valid". I believe GitHub checks it against the repository. Let me do a quick commit and verify.

If not, we could use https://github.com/mszostok/codeowners-validator although it seems to be not maintained anymore.

[dhruvmanila]

Hmm, I think GitHub seems to be only checking for syntax. Also, the codeowners-validator is giving me segmentation fault :(

[dhruvmanila]

The path could contain patterns as well but if we don't use patterns then we could do a manual check on just the existence of path in CI.

[charliermarsh]

In that case, I might vote to only include the folders for which we're enforcing rules, and add them as we go. What do you think?

[dhruvmanila]

Yeah, makes sense. Do you have any other folders in mind? (I'll comment out the rest before merging)

[charliermarsh]

Na, that's fine, I may add some later :)

Also: it may be easier just to remove rather than comment-out, since they'll probably get stale if we don't maintain them?

[charliermarsh]

Thanks!