Skip to content

[ty] Re-enable fuzzer seeds that are no longer slow #20937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

[ty] Re-enable fuzzer seeds that are no longer slow #20937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ jobs:
- determine_changes
# Only runs on pull requests, since that is the only we way we can find the base version for comparison.
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && github.event_name == 'pull_request' && (needs.determine_changes.outputs.ty == 'true' || needs.determine_changes.outputs.py-fuzzer == 'true') }}
timeout-minutes: 20
timeout-minutes: 5
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
Expand Down
7 changes: 2 additions & 5 deletions python/py-fuzzer/fuzz.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,16 +152,13 @@ def print_description(self, index: int, num_seeds: int) -> None:

def fuzz_code(seed: Seed, args: ResolvedCliArgs) -> FuzzResult:
"""Return a `FuzzResult` instance describing the fuzzing result from this seed."""
# TODO debug slowness of these seeds
skip_check = seed in {32, 56, 208}

Comment on lines -155 to -157
Copy link
Member

@MichaReiser MichaReiser Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so we're back to that one failing seed (that panics)

Copy link
Member Author

@AlexWaygood AlexWaygood Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully...!

code = generate_random_code(seed)
bug_found = False
minimizer_callback: Callable[[str], bool] | None = None

if args.baseline_executable_path is None:
only_new_bugs = False
if not skip_check and contains_bug(
if contains_bug(
code, executable=args.executable, executable_path=args.test_executable_path
):
bug_found = True
Expand All @@ -172,7 +169,7 @@ def fuzz_code(seed: Seed, args: ResolvedCliArgs) -> FuzzResult:
)
else:
only_new_bugs = True
if not skip_check and contains_new_bug(
if contains_new_bug(
code,
executable=args.executable,
test_executable_path=args.test_executable_path,
Expand Down