-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ty] Truncate Literal type display in some situations #20928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexWaygood
merged 2 commits into
astral-sh:main
from
InvalidPathException:invalid/truncate-wide-literals
Oct 17, 2025
Merged
[ty] Truncate Literal type display in some situations #20928
AlexWaygood
merged 2 commits into
astral-sh:main
from
InvalidPathException:invalid/truncate-wide-literals
Oct 17, 2025
+158
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Contributor
|
353076c to
d4c6ac0
Compare
AlexWaygood
approved these changes
Oct 17, 2025
Member
AlexWaygood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ty#1369
Test Plan
A new mdtest case is created
Union[Literal[1, 2, 3, 4, 5, 6, 7, 8], A, B, C, D, E, F]->Literal[1, 2, 3, 4, 5, ... omitted 3 literals] | A | B | ... omitted 4 union elementsbecause there was no appropriate existing case.The non-truncation case for reveal_type has many existing tests to verify, for example,
crates/ty_python_semantic/resources/mdtest/subscript/tuple.md.Tentatively setting truncation threshold to 7. When truncated, we keep the first 5 elements.