Skip to content

[ty] Fixed bug in semantic token provider for parameters. #19418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2025
Merged

[ty] Fixed bug in semantic token provider for parameters. #19418

merged 2 commits into from
Jul 18, 2025

Conversation

@UnboundVariable
Copy link
Collaborator

@UnboundVariable UnboundVariable commented Jul 18, 2025

This fixes astral-sh/ty#832.

New tests were added to prevent future regressions.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

mypy_primer results

No ecosystem changes detected ✅
No memory usage changes detected ✅

@MichaReiser MichaReiser added bug Something isn't working server Related to the LSP server ty Multi-file analysis & type inference labels Jul 18, 2025
@UnboundVariable UnboundVariable merged commit c7640a4 into astral-sh:main Jul 18, 2025
40 checks passed
@UnboundVariable UnboundVariable deleted the semantic_token_param branch July 18, 2025 07:02
dcreager added a commit that referenced this pull request Jul 18, 2025
@dcreager
Merge branch 'main' into dcreager/smoosh-reachability
31934ad 
* main:
  [ty] Use `…` as the "cut" indicator in diagnostic rendering (#19420)
  [ty] synthesize __setattr__ for frozen dataclasses (#19307)
  [ty] Fixed bug in semantic token provider for parameters. (#19418)
  [ty] Shrink reachability constraints (#19410)
  Move JUnit rendering to `ruff_db` (#19370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@carljm carljm Awaiting requested review from carljm carljm is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

@sharkdp sharkdp Awaiting requested review from sharkdp sharkdp is a code owner

@dcreager dcreager Awaiting requested review from dcreager dcreager is a code owner

Assignees

No one assigned

Labels

bug Something isn't working server Related to the LSP server ty Multi-file analysis & type inference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent syntax highlighting for keyword-only argument types

2 participants

@UnboundVariable @MichaReiser