Skip to content

Conversation

@AlexWaygood
Copy link
Member

Summary

  • Convert tests demonstrating our resilience to malformed/absent version fields in pyvenf.cfg files to mdtests. Also make them more expansive.
  • Convert the regression test I added in [ty] Add regression test for fixed pyvenv.cfg parsing bug #18157 to an mdtest
  • Add comments next to unit tests that cannot be converted to mdtests (but where it's not obvious why they can't) so I don't have to do this exercise again 😄
  • In site_packages.rs, factor out the logic for figuring out where we expect the system-installation site-packages to be. Currently we have the same logic twice.

Test Plan

cargo test -p ty_python_semantic

@AlexWaygood AlexWaygood added internal An internal refactor or improvement ty Multi-file analysis & type inference labels May 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2025

mypy_primer results

No ecosystem changes detected ✅

@AlexWaygood AlexWaygood force-pushed the alex/site-packages-mdtest branch from ddccc17 to 4a51c9d Compare May 29, 2025 16:28
@AlexWaygood AlexWaygood merged commit ad2f667 into main May 30, 2025
35 checks passed
@AlexWaygood AlexWaygood deleted the alex/site-packages-mdtest branch May 30, 2025 06:32
dcreager added a commit that referenced this pull request May 30, 2025
* main:
  [ty] support callability of bound/constrained typevars (#18389)
  [ty] Minor tweaks to "list all members" docs and tests (#18388)
  [ty] Fix broken property tests for disjointness (#18384)
  [ty] List available members for a given type (#18251)
  [`airflow`] Add unsafe fix for module moved cases (`AIR312`) (#18363)
  Add a `SourceFile` to `OldDiagnostic` (#18356)
  Update salsa past generational id change (#18362)
  [`airflow`] Add unsafe fix for module moved cases (`AIR311`) (#18366)
  [`airflow`] Add unsafe fix for module moved cases (`AIR301`) (#18367)
  [ty] Improve tests for `site-packages` discovery (#18374)
  [ty] _typeshed.Self is not a special form (#18377)
  [ty] Callable types are disjoint from non-callable `@final` nominal instance types (#18368)
  [ty] Add diagnosis for function with no return statement but with return type annotation (#18359)
  [`airflow`] Add unsafe fix module moved cases (`AIR302`) (#18093)
  Rename `ruff_linter::Diagnostic` to `OldDiagnostic` (#18355)
  [`refurb`] Add coverage of `set` and `frozenset` calls (`FURB171`) (#18035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement ty Multi-file analysis & type inference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants