Add offset method to ruff_python_trivia::Cursor
#18371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Two
Parserstructs in thety_testcrate haveoffset()andskip_whitespacemethods that are identical in their implementations. These methods feel like they could live just as well on theruff_python_triviacrate'sCursorstruct, which would reduce code duplication. (Edit: following code review, this PR now only adds theoffsetmethod to theCursorstruct.)The short-term motivation for doing this is that I found myself needing them yet again for another parsing task in #18057 -- but it seems like a reasonable thing to do anyway, so I'm splitting it out into a standalone PR.
Test Plan
cargo test -p ty_test