Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff check --add-noqa doesn't respect [tool.ruff.lint] exclusions #13423

Closed
charliermarsh opened this issue Sep 20, 2024 · 0 comments · Fixed by #13427
Closed

ruff check --add-noqa doesn't respect [tool.ruff.lint] exclusions #13423

charliermarsh opened this issue Sep 20, 2024 · 0 comments · Fixed by #13427
Assignees
@charliermarsh
Labels
bug Something isn't working help wanted Contributions especially welcome

Comments

@charliermarsh
Copy link
Member

It will run over all included files, even if the linter excludes them. As such, --add-noqa will modify files that wouldn't be reported on with ruff check.
@charliermarsh charliermarsh added bug Something isn't working help wanted Contributions especially welcome labels Sep 20, 2024
@charliermarsh charliermarsh self-assigned this Sep 20, 2024
@charliermarsh charliermarsh mentioned this issue Sep 20, 2024
Merged
charliermarsh added a commit that referenced this issue Sep 20, 2024
@charliermarsh
Respect lint.exclude in ruff check --add-noqa (#13427)
2823487 
## Summary

Closes #13423.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working help wanted Contributions especially welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect lint.exclude in ruff check --add-noqa astral-sh/ruff
1 participant
@charliermarsh