[ty] Request configuration from client (#18984)

## Summary

This PR makes the necessary changes to the server that it can request
configurations from the client using the `configuration` request.
This PR doesn't make use of the request yet. It only sets up the
foundation (mainly the coordination between client and server)
so that future PRs could pull specific settings. 

I plan to use this for pulling the Python environment from the Python
extension.

Deno does something very similar to this.

## Test Plan

Tested that diagnostics are still shown.

Author: MichaReiser

crates/ruff_db/src/files.rs

@@ -263,12 +263,23 @@ impl Files {
 
 impl fmt::Debug for Files {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        let mut map = f.debug_map();
+        if f.alternate() {
+            let mut map = f.debug_map();
 
-        for entry in self.inner.system_by_path.iter() {
-            map.entry(entry.key(), entry.value());
+            for entry in self.inner.system_by_path.iter() {
+                map.entry(entry.key(), entry.value());
+            }
+            map.finish()
+        } else {
+            f.debug_struct("Files")
+                .field("system_by_path", &self.inner.system_by_path.len())
+                .field(
+                    "system_virtual_by_path",
+                    &self.inner.system_virtual_by_path.len(),
+                )
+                .field("vendored_by_path", &self.inner.vendored_by_path.len())
+                .finish()
         }
-        map.finish()
     }
 }
 

crates/ty_project/src/db.rs

@@ -1,3 +1,4 @@
+use std::fmt::Formatter;
 use std::panic::{AssertUnwindSafe, RefUnwindSafe};
 use std::sync::Arc;
 use std::{cmp, fmt};
@@ -146,6 +147,16 @@ impl ProjectDatabase {
     }
 }
 
+impl std::fmt::Debug for ProjectDatabase {
+    fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
+        f.debug_struct("ProjectDatabase")
+            .field("project", &self.project)
+            .field("files", &self.files)
+            .field("system", &self.system)
+            .finish_non_exhaustive()
+    }
+}
+
 /// Stores memory usage information.
 pub struct SalsaMemoryDump {
     total_fields: usize,

crates/ty_project/src/lib.rs

@@ -55,6 +55,7 @@ pub fn default_lints_registry() -> LintRegistry {
 ///    it remains the same project. That's why program is a narrowed view of the project only
 ///    holding on to the most fundamental settings required for checking.
 #[salsa::input]
+#[derive(Debug)]
 pub struct Project {
     /// The files that are open in the project.
     ///

crates/ty_server/src/server.rs

@@ -136,7 +136,7 @@ impl Server {
                 &client_capabilities,
                 position_encoding,
                 global_options,
-                &workspaces,
+                workspaces,
             )?,
             client_capabilities,
         })
@@ -227,12 +227,10 @@ impl ServerPanicHookHandler {
             writeln!(stderr, "{panic_info}\n{backtrace}").ok();
 
             if let Some(client) = hook_client.upgrade() {
-                client
-                    .show_message(
-                        "The ty language server exited with a panic. See the logs for more details.",
-                        MessageType::ERROR,
-                    )
-                    .ok();
+                client.show_message(
+                    "The ty language server exited with a panic. See the logs for more details.",
+                    MessageType::ERROR,
+                );
             }
         }));
 

crates/ty_server/src/server/api.rs

@@ -160,7 +160,7 @@ where
         };
 
         let db = match &path {
-            AnySystemPath::System(path) => match session.project_db_for_path(path.as_std_path()) {
+            AnySystemPath::System(path) => match session.project_db_for_path(path) {
                 Some(db) => db.clone(),
                 None => session.default_project_db().clone(),
             },
@@ -224,17 +224,14 @@ where
                         request.id,
                         request.method
                     );
-                    if client.retry(request).is_ok() {
-                        return None;
-                    }
+                    client.retry(request);
+                } else {
+                    tracing::trace!(
+                        "request id={} was cancelled by salsa, sending content modified",
+                        id
+                    );
+                    respond_silent_error(id.clone(), client, R::salsa_cancellation_error());
                 }
-
-                tracing::trace!(
-                    "request id={} was cancelled by salsa, sending content modified",
-                    id
-                );
-
-                respond_silent_error(id.clone(), client, R::salsa_cancellation_error());
                 None
             } else {
                 Some(Err(Error {
@@ -343,17 +340,13 @@ fn respond<Req>(
         tracing::error!("An error occurred with request ID {id}: {err}");
         client.show_error_message("ty encountered a problem. Check the logs for more details.");
     }
-    if let Err(err) = client.respond(id, result) {
-        tracing::error!("Failed to send response: {err}");
-    }
+    client.respond(id, result);
 }
 
 /// Sends back an error response to the server using a [`Client`] without showing a warning
 /// to the user.
 fn respond_silent_error(id: RequestId, client: &Client, error: lsp_server::ResponseError) {
-    if let Err(err) = client.respond_err(id, error) {
-        tracing::error!("Failed to send response: {err}");
-    }
+    client.respond_err(id, error);
 }
 
 /// Tries to cast a serialized request from the server into

crates/ty_server/src/server/api/diagnostics.rs

@@ -1,4 +1,3 @@
-use lsp_server::ErrorCode;
 use lsp_types::notification::PublishDiagnostics;
 use lsp_types::{
     CodeDescription, Diagnostic, DiagnosticRelatedInformation, DiagnosticSeverity, DiagnosticTag,
@@ -46,20 +45,17 @@ impl Diagnostics {
 /// This is done by notifying the client with an empty list of diagnostics for the document.
 /// For notebook cells, this clears diagnostics for the specific cell.
 /// For other document types, this clears diagnostics for the main document.
-pub(super) fn clear_diagnostics(key: &DocumentKey, client: &Client) -> Result<()> {
+pub(super) fn clear_diagnostics(key: &DocumentKey, client: &Client) {
     let Some(uri) = key.to_url() else {
         // If we can't convert to URL, we can't clear diagnostics
-        return Ok(());
+        return;
     };
 
-    client
-        .send_notification::<PublishDiagnostics>(PublishDiagnosticsParams {
-            uri,
-            diagnostics: vec![],
-            version: None,
-        })
-        .with_failure_code(ErrorCode::InternalError)?;
-    Ok(())
+    client.send_notification::<PublishDiagnostics>(PublishDiagnosticsParams {
+        uri,
+        diagnostics: vec![],
+        version: None,
+    });
 }
 
 /// Publishes the diagnostics for the given document snapshot using the [publish diagnostics
@@ -96,22 +92,20 @@ pub(super) fn publish_diagnostics(
 
     // Sends a notification to the client with the diagnostics for the document.
     let publish_diagnostics_notification = |uri: Url, diagnostics: Vec<Diagnostic>| {
-        client
-            .send_notification::<PublishDiagnostics>(PublishDiagnosticsParams {
-                uri,
-                diagnostics,
-                version: Some(snapshot.query().version()),
-            })
-            .with_failure_code(lsp_server::ErrorCode::InternalError)
+        client.send_notification::<PublishDiagnostics>(PublishDiagnosticsParams {
+            uri,
+            diagnostics,
+            version: Some(snapshot.query().version()),
+        });
     };
 
     match diagnostics {
         Diagnostics::TextDocument(diagnostics) => {
-            publish_diagnostics_notification(url, diagnostics)?;
+            publish_diagnostics_notification(url, diagnostics);
         }
         Diagnostics::NotebookDocument(cell_diagnostics) => {
             for (cell_url, diagnostics) in cell_diagnostics {
-                publish_diagnostics_notification(cell_url, diagnostics)?;
+                publish_diagnostics_notification(cell_url, diagnostics);
             }
         }
     }

crates/ty_server/src/server/api/notifications/cancel.rs

@@ -20,7 +20,7 @@ impl SyncNotificationHandler for CancelNotificationHandler {
             lsp_types::NumberOrString::String(id) => id.into(),
         };
 
-        let _ = client.cancel(session, id);
+        client.cancel(session, id);
 
         Ok(())
     }

crates/ty_server/src/server/api/notifications/did_change.rs

@@ -39,7 +39,7 @@ impl SyncNotificationHandler for DidChangeTextDocumentHandler {
 
         match key.path() {
             AnySystemPath::System(path) => {
-                let db = match session.project_db_for_path_mut(path.as_std_path()) {
+                let db = match session.project_db_for_path_mut(path) {
                     Some(db) => db,
                     None => session.default_project_db_mut(),
                 };

crates/ty_server/src/server/api/notifications/did_change_watched_files.rs

@@ -1,5 +1,4 @@
 use crate::server::Result;
-use crate::server::api::LSPResult;
 use crate::server::api::diagnostics::publish_diagnostics;
 use crate::server::api::traits::{NotificationHandler, SyncNotificationHandler};
 use crate::session::Session;
@@ -45,7 +44,7 @@ impl SyncNotificationHandler for DidChangeWatchedFiles {
                 }
             };
 
-            let Some(db) = session.project_db_for_path(system_path.as_std_path()) else {
+            let Some(db) = session.project_db_for_path(&system_path) else {
                 tracing::trace!(
                     "Ignoring change event for `{system_path}` because it's not in any workspace"
                 );
@@ -103,13 +102,11 @@ impl SyncNotificationHandler for DidChangeWatchedFiles {
 
         if project_changed {
             if client_capabilities.diagnostics_refresh {
-                client
-                    .send_request::<types::request::WorkspaceDiagnosticRefresh>(
-                        session,
-                        (),
-                        |_, ()| {},
-                    )
-                    .with_failure_code(lsp_server::ErrorCode::InternalError)?;
+                client.send_request::<types::request::WorkspaceDiagnosticRefresh>(
+                    session,
+                    (),
+                    |_, ()| {},
+                );
             } else {
                 for key in session.text_document_keys() {
                     publish_diagnostics(session, &key, client)?;
@@ -120,9 +117,7 @@ impl SyncNotificationHandler for DidChangeWatchedFiles {
         }
 
         if client_capabilities.inlay_refresh {
-            client
-                .send_request::<types::request::InlayHintRefreshRequest>(session, (), |_, ()| {})
-                .with_failure_code(lsp_server::ErrorCode::InternalError)?;
+            client.send_request::<types::request::InlayHintRefreshRequest>(session, (), |_, ()| {});
         }
 
         Ok(())

crates/ty_server/src/server/api/notifications/did_close.rs

@@ -41,6 +41,8 @@ impl SyncNotificationHandler for DidCloseTextDocumentHandler {
             );
         }
 
-        clear_diagnostics(&key, client)
+        clear_diagnostics(&key, client);
+
+        Ok(())
     }
 }