Skip to content

Commit 529e5fa

Browse files
authored
[ty] Ecosystem analyzer: timing report (#20571)
## Summary Generate a timing diff across the whole ecosystem and deploy it to CloudFlare pages. The timing information is collected already, we just need to create and upload the HTML report. The timing results are just based on a single run. No statistical analysis across multiple runs or similar is performed. This means that results can be noisy, as can be seen on this PR, where we see slowdowns up to 1.26× and speedups down to 0.89×, even though the change should be neutral. Across all projects, these random events cancel out and we see an average factor of 1.01×. So I think this feature can still be interesting, given that it comes "for free". We just need to keep in mind that it will be noisy, and shouldn't read too much into these results. ## Test Plan CI run on this PR (see the new *timing results* link).
1 parent efbb80f commit 529e5fa

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

.github/workflows/ty-ecosystem-analyzer.yaml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,14 @@ jobs:
9595
--new-name "$REF_NAME" \
9696
--output diff-statistics.md
9797
98+
ecosystem-analyzer \
99+
generate-timing-diff \
100+
diagnostics-old.json \
101+
diagnostics-new.json \
102+
--old-name "main (merge base)" \
103+
--new-name "$REF_NAME" \
104+
--output-html dist/timing.html
105+
98106
echo '## `ecosystem-analyzer` results' > comment.md
99107
echo >> comment.md
100108
cat diff-statistics.md >> comment.md
@@ -118,7 +126,7 @@ jobs:
118126
DEPLOYMENT_URL: ${{ steps.deploy.outputs.pages-deployment-alias-url }}
119127
run: |
120128
echo >> comment.md
121-
echo "**[Full report with detailed diff]($DEPLOYMENT_URL/diff)**" >> comment.md
129+
echo "**[Full report with detailed diff]($DEPLOYMENT_URL/diff)** ([timing results]($DEPLOYMENT_URL/timing))" >> comment.md
122130
123131
- name: Upload comment
124132
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
@@ -137,3 +145,9 @@ jobs:
137145
with:
138146
name: diff.html
139147
path: dist/diff.html
148+
149+
- name: Upload timing diff
150+
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
151+
with:
152+
name: timing.html
153+
path: dist/timing.html

0 commit comments

Comments
 (0)