[ty] Do not treat tuple types as ever being single-valued

Author: AlexWaygood

crates/ty_python_semantic/src/types.rs

@@ -2435,7 +2435,6 @@ impl<'db> Type<'db> {
                 false
             }
 
-            Type::Tuple(tuple) => tuple.is_single_valued(db),
             Type::NominalInstance(instance) => instance.is_single_valued(db),
 
             Type::BoundSuper(_) => {
@@ -2446,6 +2445,7 @@ impl<'db> Type<'db> {
             Type::TypeIs(type_is) => type_is.is_bound(db),
 
             Type::Dynamic(_)
+            | Type::Tuple(..)
             | Type::Never
             | Type::Union(..)
             | Type::Intersection(..)

crates/ty_python_semantic/src/types/tuple.rs

@@ -280,10 +280,6 @@ impl<'db> TupleType<'db> {
             .is_disjoint_from_impl(db, other.tuple(db), visitor)
     }
 
-    pub(crate) fn is_single_valued(self, db: &'db dyn Db) -> bool {
-        self.tuple(db).is_single_valued(db)
-    }
-
     pub(crate) fn truthiness(self, db: &'db dyn Db) -> Truthiness {
         self.tuple(db).truthiness()
     }
@@ -469,10 +465,6 @@ impl<'db> FixedLengthTuple<Type<'db>> {
                 .zip(&other.0)
                 .all(|(self_ty, other_ty)| self_ty.is_equivalent_to(db, *other_ty))
     }
-
-    fn is_single_valued(&self, db: &'db dyn Db) -> bool {
-        self.0.iter().all(|ty| ty.is_single_valued(db))
-    }
 }
 
 #[allow(unsafe_code)]
@@ -1202,13 +1194,6 @@ impl<'db> Tuple<Type<'db>> {
         // both.
         false
     }
-
-    fn is_single_valued(&self, db: &'db dyn Db) -> bool {
-        match self {
-            Tuple::Fixed(tuple) => tuple.is_single_valued(db),
-            Tuple::Variable(_) => false,
-        }
-    }
 }
 
 impl<T> From<FixedLengthTuple<T>> for Tuple<T> {