Use temp dir implementation from cli tests

Author: dhruvmanila

Cargo.lock

@@ -38,6 +38,7 @@ tracing = { workspace = true }
 tracing-subscriber = { workspace = true, features = ["chrono"] }
 
 [dev-dependencies]
+dunce = { workspace = true }
 insta = { workspace = true, features = ["filters", "json"] }
 regex = { workspace = true }
 tempfile = { workspace = true }

crates/ty_server/Cargo.toml

@@ -306,49 +306,35 @@ impl Drop for ServerPanicHookHandler {
 mod tests {
     use anyhow::Result;
     use lsp_types::notification::PublishDiagnostics;
-    use regex::escape;
     use ruff_db::system::SystemPath;
-    use tempfile::TempDir;
 
     use crate::session::ClientOptions;
     use crate::test::TestServerBuilder;
 
-    fn tempdir_filter(temp_dir: &TempDir) -> String {
-        format!(r"{}\\?/?", escape(temp_dir.path().to_str().unwrap()))
-    }
-
     #[test]
     fn initialization() -> Result<()> {
-        let server = TestServerBuilder::new()
+        let server = TestServerBuilder::new()?
             .build()?
             .wait_until_workspaces_are_initialized()?;
 
         let initialization_result = server.initialization_result().unwrap();
 
-        insta::with_settings!({
-            filters => vec![(tempdir_filter(server.temp_dir()).as_str(), "[TMP]/")]
-        }, {
         insta::assert_json_snapshot!("initialization", initialization_result);
-        });
 
         Ok(())
     }
 
     #[test]
     fn initialization_with_workspace() -> Result<()> {
         let workspace_root = SystemPath::new("foo");
-        let server = TestServerBuilder::new()
+        let server = TestServerBuilder::new()?
             .with_workspace(workspace_root, ClientOptions::default())?
             .build()?
             .wait_until_workspaces_are_initialized()?;
 
         let initialization_result = server.initialization_result().unwrap();
 
-        insta::with_settings!({
-            filters => vec![(tempdir_filter(server.temp_dir()).as_str(), "[TMP]/")]
-        }, {
         insta::assert_json_snapshot!("initialization_with_workspace", initialization_result);
-        });
 
         Ok(())
     }
@@ -362,21 +348,17 @@ def foo() -> str:
     return 42
 ";
 
-        let mut server = TestServerBuilder::new()
+        let mut server = TestServerBuilder::new()?
             .with_workspace(workspace_root, ClientOptions::default())?
-            .write_file(foo, foo_content)?
+            .with_file(foo, foo_content)?
             .enable_pull_diagnostics(false)
             .build()?
             .wait_until_workspaces_are_initialized()?;
 
         server.open_text_document(foo, &foo_content);
         let diagnostics = server.await_notification::<PublishDiagnostics>()?;
 
-        insta::with_settings!({
-            filters => vec![(tempdir_filter(server.temp_dir()).as_str(), "[TMP]/")]
-        }, {
-            insta::assert_debug_snapshot!(diagnostics);
-        });
+        insta::assert_debug_snapshot!(diagnostics);
 
         Ok(())
     }
@@ -390,21 +372,17 @@ def foo() -> str:
     return 42
 ";
 
-        let mut server = TestServerBuilder::new()
-            .write_file(foo, foo_content)?
+        let mut server = TestServerBuilder::new()?
             .with_workspace(workspace_root, ClientOptions::default())?
+            .with_file(foo, foo_content)?
             .enable_pull_diagnostics(true)
             .build()?
             .wait_until_workspaces_are_initialized()?;
 
         server.open_text_document(foo, &foo_content);
         let diagnostics = server.document_diagnostic_request(foo)?;
 
-        insta::with_settings!({
-            filters => vec![(tempdir_filter(server.temp_dir()).as_str(), "[TMP]/")]
-        }, {
         insta::assert_debug_snapshot!(diagnostics);
-        });
 
         Ok(())
     }

crates/ty_server/src/server.rs

@@ -10,7 +10,7 @@ PublishDiagnosticsParams {
         password: None,
         host: None,
         port: None,
-        path: "[TMP]/src/foo.py",
+        path: "<temp_dir>/src/foo.py",
         query: None,
         fragment: None,
     },
@@ -70,7 +70,7 @@ PublishDiagnosticsParams {
                                 password: None,
                                 host: None,
                                 port: None,
-                                path: "[TMP]/src/foo.py",
+                                path: "<temp_dir>/src/foo.py",
                                 query: None,
                                 fragment: None,
                             },

crates/ty_server/src/snapshots/ty_server__server__tests__publish_diagnostics_on_did_open.snap

@@ -64,7 +64,7 @@ Report(
                                             password: None,
                                             host: None,
                                             port: None,
-                                            path: "[TMP]/src/foo.py",
+                                            path: "<temp_dir>/src/foo.py",
                                             query: None,
                                             fragment: None,
                                         },