Add failing incomplete markers scenarios #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
approved these changes
Jul 9, 2024
| description = ''' | ||
| The root cause the resolver to fork over `a`, but the markers on the variant | ||
| of `a` don't cover the entire marker space, they are missing Python 3.10. | ||
| Later, we have a dependency this very hole, which we still need to select. |
There was a problem hiding this comment.
Can you say what the expected versus actual result is here? Just a quick prose mention is fine. (We don't have a structured way yet of describing universal resolutions in packse scenarios.)
There was a problem hiding this comment.
Add a sentence that we're testing for c being present
We're currently (astral-sh/uv#4732) failing to install `c` from this scenario: ``` $ echo "fork-incomplete-markers-8137fed5" | uv pip compile --index-url http://127.0.0.1:3141 -p 3.9 --universal - Resolved 4 packages in 38ms # This file was autogenerated by uv via the following command: # uv pip compile -p 3.9 --universal - fork-incomplete-markers-8137fed5==0.0.0 fork-incomplete-markers-a-8137fed5==1.0.0 ; python_version < '3.10' # via fork-incomplete-markers-8137fed5 fork-incomplete-markers-a-8137fed5==2.0.0 ; python_version >= '3.11' # via fork-incomplete-markers-8137fed5 fork-incomplete-markers-b-8137fed5==1.0.0 # via fork-incomplete-markers-8137fed5 ``` This is one particular scenario that we need to test for solving astral-sh/uv#4732 I had to update the lockfile for the recent uv lockfile changes.
konstin
force-pushed
the
konsti/failing-incomplete-marker-scenario
branch
from
c305fe2
to
add2be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently (astral-sh/uv#4732) failing to install
cfrom the added scenario:This is one particular scenario that we need to test for solving astral-sh/uv#4732
I had to update the lockfile for the recent uv lockfile changes, split out to #199 which removes it from the diff here.