-
Notifications
You must be signed in to change notification settings - Fork 42
Record-like getters support #212 #216 rebased #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
No, all those features aren't mandatory. We can definitely release M4 with this enhancement, but we don't plan to have a non-milestone release very soon for this project because we'd like to make some fundamental changes to its internals. Just FYI, there is a way to use milestone versions with the existing plugins, see #194 (comment). Would that help your needs, in the short term? I would be happy to finalize this change, release a new milestone, and properly document the workaround at assertj/assertj-assertions-generator-maven-plugin#93. |
Using Milestone versions with existing plugin releases would be great! I had seen @reitzig's comment but I don't understand how he forced the milestone release on it. So I would need some pointers on how to configure the plugin, I need to do this with the grade plugin by the way. |
Let me spend some time on it, I'll get back to you. |
Ah, my bad, I wasn't very clear about that. IIRC I added the new library as dependency (don't recall whether for the project or the plugin), and maybe blacklisted the original version declared by the plugin. I can check the project sources when I'm back at my work machine, but that'll be a few weeks. 🏝️ |
I added a Maven example at assertj/assertj-assertions-generator-maven-plugin#93 (comment). I'll try to achieve the same with Gradle. Not my comfort zone, though, so I might try to bother @Nava2 for some help 🙂 |
@timo-a see #194 (comment) for a Gradle workaround. |
@Nava2 what I've written at #194 (comment) seems to work fine in a sample project. Or do you see it differently? For completeness, here's my full build: plugins {
id("java")
id("org.assertj.generator") version "1.1.0"
}
group = "io.github.scordio"
version = "1.0-SNAPSHOT"
repositories {
mavenCentral()
}
dependencies {
testImplementation("org.assertj:assertj-core:3.27.3")
}
tasks.test {
useJUnitPlatform()
}
buildscript {
configurations.all {
resolutionStrategy {
force("org.assertj:assertj-assertions-generator:3.0.0-M3")
}
}
} Version 3.0.0-M3 kicks in correctly and I can see |
Oh, apologies. That would work. Sorry, I'm a little out of it today! Both are options. |
This is a friendly rebase of #217 to resume work on solving #212. Initially it is simply a rebase of the original PR by @Berlizov (feel free to reset your branch on my rebased version of yours and continue work on the original PR).
I have an interest in having that feature implemented very soon and also released as soon as possible¹ and am willing to contribute within my capacity. Let me know what I can do to get this feature merged!
[1] Do we really need another 10 features for another Milestone before can see a new release? Having #194 of Milestone 3 available through plugins would already be a benefit because JDK 17+ (and thus Spring Boot 3+) users won't have to employ the template workaround anymore. Surely some of the issues currently in M-4 can be postponed onto a later minor release?