Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown rendering bug #25

Closed
MichielDeMey opened this issue Aug 26, 2015 · 3 comments
Closed

Markdown rendering bug #25

MichielDeMey opened this issue Aug 26, 2015 · 3 comments

Comments

@MichielDeMey
Copy link

Hey guys, I'd like to report a strange issue with markdown rendering.
This is most likely a bug in the markdown renderer that you use, however I could not find which one.

The following bug is observed:

---
title: Foo

---

# This is rendered as a header

<section>

  # This is not rendered as a header

</section>

output:

<h1>This is rendered as a header</h1>

<section>

  # This is not rendered as a header

</section>

The first header is rendered in html as an h1, however the second header inside the section tags is ignored and outputted literally.

I'm including the content as suggested in the documentation:

{{#markdown }}
  {{> body  }}
{{/markdown }}

Using grunt-assemble 0.4.0

Technically, this should work, right? Any ideas?

@MichielDeMey
Copy link
Author

Apparently it's a known issue with Marked.
markedjs/marked#488

@bchavezgd
Copy link

that's an issue with markdown itself. you can't put html inside markdown inside html, it won't render.

see daringfireball.net reason's why

@jonschlinkert
Copy link
Member

you can't put html inside markdown inside html, it won't render.

yeah that's correct. Also, I think the markdown helpers in grunt-assemble use marked (from the handlebars-helpers lib), which does not follow commonmark spec.

Also fwiw in the 0.6. branch of handlebars-helpers, the markdown helpers were updated to use remarkable, a much better markdown parser that follows commonmark.

closing since this isn't really an issue, but feel free to continue the conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants