Skip to content
This repository was archived by the owner on May 7, 2024. It is now read-only.

Commit 5e5111a

Browse files
committed
fixed various issues per @anurse
1 parent 92a54f6 commit 5e5111a

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

PullRequestR/android/app/build.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ dependencies {
2929
testImplementation 'junit:junit:4.12'
3030
androidTestImplementation 'com.android.support.test:runner:1.0.2'
3131
androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
32-
implementation group: 'com.microsoft.signalr', name: 'signalr', version: '1.0.0-preview4-t000'
32+
implementation 'com.microsoft.signalr:signalr:1.0.0-preview3-35501'
33+
implementation 'io.reactivex.rxjava2:rxjava:2.2.2'
3334
implementation group: 'org.slf4j', name: 'slf4j-android', version: '1.7.7'
3435
implementation 'com.squareup.picasso:picasso:2.71828'
3536
}

PullRequestR/android/app/src/main/java/com/example/pullrequestr/MainActivity.java

+2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ protected void onCreate(Bundle savedInstanceState) {
3030
super.onCreate(savedInstanceState);
3131
setContentView(R.layout.activity_main);
3232

33+
// This URL does NOT need to be suffixed with the "negotiate" endpoint,
34+
// the /api endpoint is correct.
3335
String url = "https://YOUR-FUNCTION-URI.azurewebsites.net/api";
3436
PullRequestAdapter adapter = new PullRequestAdapter(this, pullRequests);
3537
ListView lvItems = (ListView)findViewById(R.id.lvPullRequestList);

PullRequestR/android/build.gradle

-3
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,6 @@ allprojects {
1919
repositories {
2020
google()
2121
jcenter()
22-
maven {
23-
url 'https://www.myget.org/F/ping-verify/maven/'
24-
}
2522
}
2623
}
2724

PullRequestR/function-dotnet/Negotiate.cs

+3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313

1414
namespace Company.Function
1515
{
16+
// The class AND the value of the FunctionName parameter must
17+
// both be set to "negotiate" as the SignalR client expects
18+
// to call this specific endpoint.
1619
public static class negotiate
1720
{
1821
[FunctionName("negotiate")]

0 commit comments

Comments
 (0)