Removing dictionary overloads from MapRoute.

Author: harshgMSFT

src/Microsoft.AspNet.Routing/RouteBuilderExtensions.cs

@@ -23,71 +23,14 @@ public static IRouteBuilder MapRoute(this IRouteBuilder routeCollectionBuilder,
                                              string template,
                                              object defaults)
         {
-            MapRoute(routeCollectionBuilder, name, template, new RouteValueDictionary(defaults));
-            return routeCollectionBuilder;
-        }
-
-        public static IRouteBuilder MapRoute(this IRouteBuilder routeCollectionBuilder,
-                                             string name,
-                                             string template,
-                                             IDictionary<string, object> defaults)
-        {
-            if (routeCollectionBuilder.DefaultHandler == null)
-            {
-                throw new InvalidOperationException(Resources.DefaultHandler_MustBeSet);
-            }
-
-            var inlineConstraintResolver = routeCollectionBuilder
-                                                    .ServiceProvider
-                                                    .GetService<IInlineConstraintResolver>();
-
-            routeCollectionBuilder.Routes.Add(new TemplateRoute(routeCollectionBuilder.DefaultHandler,
-                                              name,
-                                              template,
-                                              defaults,
-                                              constraints: null,
-                                              inlineConstraintResolver: inlineConstraintResolver));
-            return routeCollectionBuilder;
+            return MapRoute(routeCollectionBuilder, name, template, defaults, constraints: null);
         }
 
         public static IRouteBuilder MapRoute(this IRouteBuilder routeCollectionBuilder,
                                              string name,
                                              string template,
                                              object defaults,
                                              object constraints)
-        {
-            MapRoute(routeCollectionBuilder,
-                     name,
-                     template,
-                     new RouteValueDictionary(defaults),
-                     new RouteValueDictionary(constraints));
-            return routeCollectionBuilder;
-        }
-
-        public static IRouteBuilder MapRoute(this IRouteBuilder routeCollectionBuilder,
-                                             string name,
-                                             string template,
-                                             object defaults,
-                                             IDictionary<string, object> constraints)
-        {
-            MapRoute(routeCollectionBuilder, name, template, new RouteValueDictionary(defaults), constraints);
-            return routeCollectionBuilder;
-        }
-
-        public static IRouteBuilder MapRoute(this IRouteBuilder routeCollectionBuilder,
-                                             string name,
-                                             string template,
-                                             IDictionary<string, object> defaults, object constraints)
-        {
-            MapRoute(routeCollectionBuilder, name, template, defaults, new RouteValueDictionary(constraints));
-            return routeCollectionBuilder;
-        }
-
-        public static IRouteBuilder MapRoute(this IRouteBuilder routeCollectionBuilder,
-                                             string name,
-                                             string template,
-                                             IDictionary<string, object> defaults,
-                                             IDictionary<string, object> constraints)
         {
             if (routeCollectionBuilder.DefaultHandler == null)
             {
@@ -100,10 +43,21 @@ public static IRouteBuilder MapRoute(this IRouteBuilder routeCollectionBuilder,
             routeCollectionBuilder.Routes.Add(new TemplateRoute(routeCollectionBuilder.DefaultHandler,
                                                                 name,
                                                                 template,
-                                                                defaults,
-                                                                constraints,
+                                                                ObjectToDictionary(defaults),
+                                                                ObjectToDictionary(constraints),
                                                                 inlineConstraintResolver));
             return routeCollectionBuilder;
         }
+
+        private static IDictionary<string, object> ObjectToDictionary(object value)
+        {
+            var dictionary = value as IDictionary<string, object>;
+            if (dictionary != null)
+            {
+                return dictionary;
+            }
+          
+            return new RouteValueDictionary(value);
+        }
     }
 }