Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

React to Sdk changes to assembly metadata #842

Merged
merged 1 commit into from
Mar 19, 2018
Merged

React to Sdk changes to assembly metadata #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions korebuild-lock.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version:2.1.0-preview2-15742
commithash:21fbb0f2c3fe4a9216e2d59632b98cfd7d685962
version:2.1.0-preview2-15744
commithash:9e15cb6062ab5b9790d3fa699e018543a6950713
1 change: 0 additions & 1 deletion samples/MusicStore/MusicStore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<Description>Music store application on ASP.NET Core</Description>
<TargetFrameworks>netcoreapp2.1;netcoreapp2.0;net461</TargetFrameworks>
<DefineConstants>$(DefineConstants);DEMO</DefineConstants>
<RazorCompileOnBuild>true</RazorCompileOnBuild>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<RuntimeIdentifiers Condition="'$(Configuration)' != 'RuntimeStore'">win7-x86;win7-x64;linux-x64;osx-x64</RuntimeIdentifiers>
<Configurations>Debug;Release;RuntimeStore</Configurations>
Expand Down
13 changes: 1 addition & 12 deletions test/MusicStore.E2ETests/Implementation/Validator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ public async Task VerifyHomePage(
}

// Verify the app is using precompiled views
Assert.Contains("MusicStore.Views, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null", responseContent);
Assert.Contains("MusicStore.Views, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null", responseContent);
}

public async Task VerifyNtlmHomePage(HttpResponseMessage response)
Expand Down Expand Up @@ -148,17 +148,6 @@ public void ValidateLayoutPage(string responseContent)
Assert.Contains("<li class=\"divider\"></li>", responseContent, StringComparison.OrdinalIgnoreCase);
}

public async Task VerifyRuntimeCompiledHomePage(HttpResponseMessage response)
{
var responseContent = await response.Content.ReadAsStringAsync();

// Smoke test to make sure the page is served correctly.
Assert.Contains("<title>Home Page – ASP.NET MVC Music Store</title>", responseContent);

// Verify the app is using a runtime compiled view
Assert.DoesNotContain("MusicStore.Views, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null", responseContent);
}

public async Task VerifyStaticContentServed()
{
_logger.LogInformation("Validating if static contents are served..");
Expand Down