This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Expand log level extension #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@muratg - do we want to have someone take a look at this? |
|
@ChrisSimmons thanks for the PR! @pakrym could you review when you have some time? |
pakrym
reviewed
Apr 10, 2018
| @@ -38,10 +38,15 @@ public void MessageOnly_LogsCorrectValues() | |||
| logger.LogError(_state); | |||
| logger.LogCritical(_state); | |||
| logger.LogDebug(_state); | |||
| logger.Log(LogLevel.Trace, _state); | |||
There was a problem hiding this comment.
Add a separate test method that calls new overloads (with exception and non zero event id)
There was a problem hiding this comment.
Sorry for the delay. I'll get to this now.
There was a problem hiding this comment.
|
Please add tests for new overloads, otherwise LGTM. |
Wire existing Log() extension with log level to use new method. Wire up level-specific extensions to use new method Rely on null argument check in new method Add overloads without EventId and exception, patterns that were already present in the level-specific methods. Hook level-specific into these new overloads. Adds to aspnet/Logging#629 and #649
|
Also, is there any value to using a |
|
Totally, bring the Theories in. |
|
OK, all set. Let me know if you have any more requested changes. |
pakrym
approved these changes
Apr 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands on #629. Changes:
EventIdand anExceptionLogDebug()andLogWarning()) to use this new methodloggerargument exception