This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Moar refactoring! #143
Merged
Moar refactoring! #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved TraceSourceLogger to Microsoft.Framework.Logging.TraceSource - Removed Logging dependency from all providers, they only need the .Interfaces reference - Moved WriteContext to the test project - Added an extension method AddTraceSource to add the TraceSource provider - Added AddLogging to the Logging project - Removed RootTraceName #142 #141 #140
ghost
added
the
| @@ -0,0 +1,27 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Do we have a script for that?
There was a problem hiding this comment.
No but I'll go ahead and do it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the .Interfaces reference
Move AddLogging to Logging #142
TraceSourceLoggerProvider > InitializeTraceSource is no use #141
WriteContext should be moved to Test #140