Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Commit 735e2bc

Browse files
authored
Merge pull request #867 from martincostello/remove-redundant-if
Remove redundant if condition from ConsoleLogger
2 parents 8f864d3 + 24c5340 commit 735e2bc

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

src/Microsoft.Extensions.Logging.Console/ConsoleLogger.cs

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -168,19 +168,16 @@ public virtual void WriteMessage(LogLevel logLevel, string logName, int eventId,
168168
logBuilder.AppendLine(exception.ToString());
169169
}
170170

171-
if (logBuilder.Length > 0)
171+
var hasLevel = !string.IsNullOrEmpty(logLevelString);
172+
// Queue log message
173+
_queueProcessor.EnqueueMessage(new LogMessageEntry()
172174
{
173-
var hasLevel = !string.IsNullOrEmpty(logLevelString);
174-
// Queue log message
175-
_queueProcessor.EnqueueMessage(new LogMessageEntry()
176-
{
177-
Message = logBuilder.ToString(),
178-
MessageColor = DefaultConsoleColor,
179-
LevelString = hasLevel ? logLevelString : null,
180-
LevelBackground = hasLevel ? logLevelColors.Background : null,
181-
LevelForeground = hasLevel ? logLevelColors.Foreground : null
182-
});
183-
}
175+
Message = logBuilder.ToString(),
176+
MessageColor = DefaultConsoleColor,
177+
LevelString = hasLevel ? logLevelString : null,
178+
LevelBackground = hasLevel ? logLevelColors.Background : null,
179+
LevelForeground = hasLevel ? logLevelColors.Foreground : null
180+
});
184181

185182
logBuilder.Clear();
186183
if (logBuilder.Capacity > 1024)
@@ -299,4 +296,4 @@ public void WriteLine(string message)
299296
}
300297
}
301298
}
302-
}
299+
}

0 commit comments

Comments
 (0)