Upgrade to VS 2017 #320
Upgrade to VS 2017 #320
Conversation
|
@ryanbrandenburg it looks like tests are failing. I think it's due to a temporary bug in vstest which runs the tests in the wrong working directory. microsoft/vstest#311 This can usually be worked around by using AppContext.BaseDirectory (netcoreapp) or AppDomain.CurrentDirectory.BaseDirectory (net451) to find test files |
| @@ -0,0 +1,23 @@ | |||
| <Project> | |||
| <Import Project="..\version.props" /> | |||
There was a problem hiding this comment.
This needs $(MSBuildThisFileDirectory). Includes are always relative to the "entry" project file.
There was a problem hiding this comment.
Not quite. Relative paths in imported projects are interpreted relative to the directory of the importing project.
There was a problem hiding this comment.
...but, the relative path of Import Project is relative to the file in which its expressed.
Or so I've been led to believe. This works in all of our other repos
There was a problem hiding this comment.
Weird. I'm getting assembly version 1.0.0.0 without it.
There was a problem hiding this comment.
Building this repo? It seems to work for me
There was a problem hiding this comment.
this repo?
No, EF, but it's the same pattern.
There was a problem hiding this comment.
Yeah, works in VS and command line. Something else must be going on since the import would fail if it couldn't find the file.
There was a problem hiding this comment.
Huh, good point. 😄 Yuck. Not something I want to debug...
There was a problem hiding this comment.
There was a problem hiding this comment.
and may the force be with you
| deploy: off | ||
| os: Visual Studio 2017 RC |
There was a problem hiding this comment.
Do we need to do this in all our repos?
There was a problem hiding this comment.
Yes. The default image doesn't have .NET Framework 4.6, which is required for dotnet-test
| <!-- TODO remove when https://github.com/dotnet/sdk/issues/396 is resolved --> | ||
| <RuntimeIdentifier Condition=" '$(TargetFramework)' != 'netcoreapp1.1' ">win7-x64</RuntimeIdentifier> | ||
| <OutputType>Exe</OutputType> | ||
| <!-- workaround issues with satellite assembly generation and --> |
There was a problem hiding this comment.
yes, that was the rest of the sentence. @ryanbrandenburg have you already opened a bug for this, or should I?
There was a problem hiding this comment.
Nvm, I verified this works on 1.0.0-rc4-004755. Will update the TODO here
|
superseded by #322 |
WIP: still needs to be verified in VS 2017
cref aspnet/Universe#469