Prevent null refs when copying a property with a null value

* Fix dotnet/aspnetcore#3559 Json Patch: System.NullReferenceException while trying to use copy operation from property with null value.

* Fix dotnet/aspnetcore#3559: Missing tests added.

Author: Iamcerba

src/Microsoft.AspNetCore.JsonPatch/Adapters/ObjectAdapter.cs

@@ -229,7 +229,7 @@ public void Copy(Operation operation, object objectToApplyTo)
             if (TryGetValue(operation.from, objectToApplyTo, operation, out var propertyValue))
             {
                 // Create deep copy
-                var copyResult = ConversionResultProvider.CopyTo(propertyValue, propertyValue.GetType());
+                var copyResult = ConversionResultProvider.CopyTo(propertyValue, propertyValue?.GetType());
                 if (copyResult.CanBeConverted)
                 {
                     Add(operation.path,

src/Microsoft.AspNetCore.JsonPatch/Internal/ConversionResultProvider.cs

@@ -39,7 +39,7 @@ public static ConversionResult CopyTo(object value, Type typeToConvertTo)
             var targetType = typeToConvertTo;
             if (value == null)
             {
-                return new ConversionResult(IsNullableType(typeToConvertTo), null);
+                return new ConversionResult(canBeConverted: true, convertedInstance: null);
             }
             else if (typeToConvertTo.IsAssignableFrom(value.GetType()))
             {

src/Microsoft.AspNetCore.JsonPatch/JsonPatchDocumentOfT.cs

@@ -503,7 +503,7 @@ public JsonPatchDocument<TModel> Move<TProp>(
         }
 
         /// <summary>
-        /// Copy the value at specified location to the target location.  Willr esult in, for example:
+        /// Copy the value at specified location to the target location.  Will result in, for example:
         /// { "op": "copy", "from": "/a/b/c", "path": "/a/b/e" }
         /// </summary>
         /// <param name="from">source location</param>

test/Microsoft.AspNetCore.JsonPatch.Test/IntegrationTests/ExpandoObjectIntegrationTest.cs

@@ -159,6 +159,25 @@ public void CopyStringProperty_ToAnotherStringProperty()
             Assert.Equal("A", targetObject.AnotherStringProperty);
         }
 
+        [Fact]
+        public void CopyNullStringProperty_ToAnotherStringProperty()
+        {
+            // Arrange
+            dynamic targetObject = new ExpandoObject();
+
+            targetObject.StringProperty = null;
+            targetObject.AnotherStringProperty = "B";
+
+            var patchDocument = new JsonPatchDocument();
+            patchDocument.Copy("StringProperty", "AnotherStringProperty");
+
+            // Act
+            patchDocument.ApplyTo(targetObject);
+
+            // Assert
+            Assert.Null(targetObject.AnotherStringProperty);
+        }
+
         [Fact]
         public void MoveIntegerValue_ToAnotherIntegerProperty()
         {

test/Microsoft.AspNetCore.JsonPatch.Test/IntegrationTests/NestedObjectIntegrationTest.cs

@@ -175,7 +175,30 @@ public void CopyStringProperty_ToAnotherStringProperty()
 
             // Assert
             Assert.Equal("A", targetObject.SimpleObject.AnotherStringProperty);
-        }       
+        }
+
+        [Fact]
+        public void CopyNullStringProperty_ToAnotherStringProperty()
+        {
+            // Arrange
+            var targetObject = new SimpleObjectWithNestedObject()
+            {
+                SimpleObject = new SimpleObject()
+                {
+                    StringProperty = null,
+                    AnotherStringProperty = "B"
+                }
+            };
+
+            var patchDocument = new JsonPatchDocument<SimpleObjectWithNestedObject>();
+            patchDocument.Copy(o => o.SimpleObject.StringProperty, o => o.SimpleObject.AnotherStringProperty);
+
+            // Act
+            patchDocument.ApplyTo(targetObject);
+
+            // Assert
+            Assert.Null(targetObject.SimpleObject.AnotherStringProperty);
+        }
 
         [Fact]
         public void Copy_DeepClonesObject()

test/Microsoft.AspNetCore.JsonPatch.Test/IntegrationTests/SimpleObjectIntegrationTest.cs

@@ -46,6 +46,26 @@ public void CopyStringProperty_ToAnotherStringProperty()
             Assert.Equal("A", targetObject.AnotherStringProperty);
         }
 
+        [Fact]
+        public void CopyNullStringProperty_ToAnotherStringProperty()
+        {
+            // Arrange
+            var targetObject = new SimpleObject()
+            {
+                StringProperty = null,
+                AnotherStringProperty = "B"
+            };
+
+            var patchDocument = new JsonPatchDocument();
+            patchDocument.Copy("StringProperty", "AnotherStringProperty");
+
+            // Act
+            patchDocument.ApplyTo(targetObject);
+
+            // Assert
+            Assert.Null(targetObject.AnotherStringProperty);
+        }
+
         [Fact]
         public void MoveIntegerProperty_ToAnotherIntegerProperty()
         {