This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Update templates to Webpack 2 #615
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll merge this at the start of next week, but posting it here as a PR first just in case anyone can spot any issues.
Moving to
awesome-typescript-loader
improves the Angular2Spa Webpack build times (down from about 7.5s to about 4s on my machine). It makes no difference to the other templates, which were already fast to build, but I've migrated them toawesome-typescript-loader
for consistency.Anyone who reads this: please let me know if you think there are any problems with this, or some opportunity to make things simpler still with Webpack 2.
Note: If you're trying to read the diff, it makes much more sense if you ignore whitespace differences (because indentation changed). This URL will give an indentation-ignoring diff: https://github.com/aspnet/JavaScriptServices/pull/615/files?w=1