Skip to content
This repository was archived by the owner on Mar 19, 2019. It is now read-only.

Commit 3e08bf8

Browse files
committed
Move tests to net472
1 parent 0a22b92 commit 3e08bf8

File tree

7 files changed

+16
-7
lines changed

7 files changed

+16
-7
lines changed

HttpSysServer.sln

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{85914BA9
4343
ProjectSection(SolutionItems) = preProject
4444
build\dependencies.props = build\dependencies.props
4545
build\Key.snk = build\Key.snk
46+
build\repo.props = build\repo.props
47+
build\sources.props = build\sources.props
4648
EndProjectSection
4749
EndProject
4850
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "shared", "shared", "{AB6964C9-A7AF-4FAC-BEA1-C8A538EC989E}"

build/dependencies.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<MicrosoftNETCoreApp20PackageVersion>2.0.9</MicrosoftNETCoreApp20PackageVersion>
1212
<MicrosoftNETCoreApp21PackageVersion>2.1.3</MicrosoftNETCoreApp21PackageVersion>
1313
<MicrosoftNETCoreApp22PackageVersion>2.2.0-preview3-27008-03</MicrosoftNETCoreApp22PackageVersion>
14+
<MicrosoftNETFrameworkReferenceAssemblies>1.0.0-alpha-004</MicrosoftNETFrameworkReferenceAssemblies>
1415
<MicrosoftNetHttpHeadersPackageVersion>2.2.0-preview3-35457</MicrosoftNetHttpHeadersPackageVersion>
1516
<MicrosoftNETTestSdkPackageVersion>15.6.1</MicrosoftNETTestSdkPackageVersion>
1617
<MicrosoftWin32RegistryPackageVersion>4.5.0</MicrosoftWin32RegistryPackageVersion>

build/sources.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
https://dotnet.myget.org/F/dotnet-core/api/v3/index.json;
99
https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json;
1010
https://dotnet.myget.org/F/aspnetcore-tools/api/v3/index.json;
11+
https://dotnet.myget.org/F/roslyn-tools/api/v3/index.json;
1112
</RestoreSources>
1213
<RestoreSources Condition="'$(DotNetBuildOffline)' != 'true'">
1314
$(RestoreSources);

test/Directory.Build.props

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<DeveloperBuildTestTfms>netcoreapp2.2</DeveloperBuildTestTfms>
66
<StandardTestTfms>$(DeveloperBuildTestTfms)</StandardTestTfms>
77
<StandardTestTfms Condition=" '$(DeveloperBuild)' != 'true' ">$(StandardTestTfms)</StandardTestTfms>
8-
<StandardTestTfms Condition=" '$(DeveloperBuild)' != 'true' AND '$(OS)' == 'Windows_NT' ">$(StandardTestTfms);net461</StandardTestTfms>
8+
<StandardTestTfms Condition=" '$(DeveloperBuild)' != 'true' AND '$(OS)' == 'Windows_NT' ">$(StandardTestTfms);net472</StandardTestTfms>
99
</PropertyGroup>
1010

1111
<ItemGroup>
@@ -15,4 +15,9 @@
1515
<PackageReference Include="xunit" Version="$(XunitPackageVersion)" />
1616
<PackageReference Include="xunit.runner.visualstudio" Version="$(XunitRunnerVisualStudioPackageVersion)" />
1717
</ItemGroup>
18+
19+
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework' ">
20+
<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="$(MicrosoftNETFrameworkReferenceAssemblies)" PrivateAssets="All" />
21+
</ItemGroup>
22+
1823
</Project>

test/Microsoft.AspNetCore.Server.HttpSys.FunctionalTests/Listener/ResponseBodyTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ public async Task ResponseBodyWriteExceptions_FirstWriteAsyncWithCanceledCancell
159159
var writeTask = context.Response.Body.WriteAsync(new byte[10], 0, 10, cts.Token);
160160
Assert.True(writeTask.IsCanceled);
161161
context.Dispose();
162-
#if NET461
162+
#if NET472
163163
// HttpClient retries the request because it didn't get a response.
164164
context = await server.AcceptAsync(Utilities.DefaultTimeout).Before(responseTask);
165165
cts = new CancellationTokenSource();
@@ -191,7 +191,7 @@ public async Task ResponseBody_FirstWriteAsyncWithCanceledCancellationToken_Canc
191191
var writeTask = context.Response.Body.WriteAsync(new byte[10], 0, 10, cts.Token);
192192
Assert.True(writeTask.IsCanceled);
193193
context.Dispose();
194-
#if NET461
194+
#if NET472
195195
// HttpClient retries the request because it didn't get a response.
196196
context = await server.AcceptAsync(Utilities.DefaultTimeout).Before(responseTask);
197197
cts = new CancellationTokenSource();

test/Microsoft.AspNetCore.Server.HttpSys.FunctionalTests/Listener/ResponseSendFileTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public async Task ResponseSendFileWriteExceptions_FirstCallWithCanceledCancellat
113113
var writeTask = context.Response.SendFileAsync(AbsoluteFilePath, 0, null, cts.Token);
114114
Assert.True(writeTask.IsCanceled);
115115
context.Dispose();
116-
#if NET461
116+
#if NET472
117117
// .NET HttpClient automatically retries a request if it does not get a response.
118118
context = await server.AcceptAsync(Utilities.DefaultTimeout).Before(responseTask);
119119
cts = new CancellationTokenSource();
@@ -145,7 +145,7 @@ public async Task ResponseSendFile_FirstSendWithCanceledCancellationToken_Cancel
145145
var writeTask = context.Response.SendFileAsync(AbsoluteFilePath, 0, null, cts.Token);
146146
Assert.True(writeTask.IsCanceled);
147147
context.Dispose();
148-
#if NET461
148+
#if NET472
149149
// .NET HttpClient automatically retries a request if it does not get a response.
150150
context = await server.AcceptAsync(Utilities.DefaultTimeout).Before(responseTask);
151151
cts = new CancellationTokenSource();

test/Microsoft.AspNetCore.Server.HttpSys.FunctionalTests/ResponseHeaderTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public async Task ResponseHeaders_ServerSendsMultiValueKnownHeaders_Success()
8383
Assert.Equal("Microsoft-HTTPAPI/2.0", response.Headers["Server"]);
8484
#if NETCOREAPP2_2 // WebHeaderCollection.GetValues() not available in CoreCLR.
8585
Assert.Equal("custom1, and custom2, custom3", response.Headers["WWW-Authenticate"]);
86-
#elif NET461
86+
#elif NET472
8787
Assert.Equal(new string[] { "custom1, and custom2", "custom3" }, response.Headers.GetValues("WWW-Authenticate"));
8888
#else
8989
#error Target framework needs to be updated
@@ -113,7 +113,7 @@ public async Task ResponseHeaders_ServerSendsCustomHeaders_Success()
113113
Assert.Equal("Microsoft-HTTPAPI/2.0", response.Headers["Server"]);
114114
#if NETCOREAPP2_2 // WebHeaderCollection.GetValues() not available in CoreCLR.
115115
Assert.Equal("custom1, and custom2, custom3", response.Headers["Custom-Header1"]);
116-
#elif NET461
116+
#elif NET472
117117
Assert.Equal(new string[] { "custom1, and custom2", "custom3" }, response.Headers.GetValues("Custom-Header1"));
118118
#else
119119
#error Target framework needs to be updated

0 commit comments

Comments
 (0)