#53 - Reduce auth exceptions for missing handlers.

Author: Tratcher

src/Microsoft.AspNet.PipelineCore/DefaultHttpContext.cs

@@ -153,13 +153,12 @@ public override IEnumerable<AuthenticationResult> Authenticate(IList<string> aut
                 throw new ArgumentNullException();
             }
             var handler = HttpAuthentication.Handler;
-            if (handler == null)
-            {
-                throw new InvalidOperationException("No authentication handlers present.");
-            }
 
             var authenticateContext = new AuthenticateContext(authenticationTypes);
-            handler.Authenticate(authenticateContext);
+            if (handler != null)
+            {
+                handler.Authenticate(authenticateContext);
+            }
 
             // Verify all types ack'd
             IEnumerable<string> leftovers = authenticationTypes.Except(authenticateContext.Accepted);
@@ -178,13 +177,12 @@ public override async Task<IEnumerable<AuthenticationResult>> AuthenticateAsync(
                 throw new ArgumentNullException();
             }
             var handler = HttpAuthentication.Handler;
-            if (handler == null)
-            {
-                throw new InvalidOperationException("No authentication handlers present.");
-            }
 
             var authenticateContext = new AuthenticateContext(authenticationTypes);
-            await handler.AuthenticateAsync(authenticateContext);
+            if (handler != null)
+            {
+                await handler.AuthenticateAsync(authenticateContext);
+            }
 
             // Verify all types ack'd
             IEnumerable<string> leftovers = authenticationTypes.Except(authenticateContext.Accepted);

src/Microsoft.AspNet.PipelineCore/DefaultHttpResponse.cs

@@ -135,13 +135,12 @@ public override void Challenge(IList<string> authenticationTypes, Authentication
             }
             HttpResponseInformation.StatusCode = 401;
             var handler = HttpAuthentication.Handler;
-            if (handler == null)
-            {
-                throw new InvalidOperationException("No authentication handlers present.");
-            }
 
             var challengeContext = new ChallengeContext(authenticationTypes, properties == null ? null : properties.Dictionary);
-            handler.Challenge(challengeContext);
+            if (handler != null)
+            {
+                handler.Challenge(challengeContext);
+            }
 
             // Verify all types ack'd
             IEnumerable<string> leftovers = authenticationTypes.Except(challengeContext.Accepted);
@@ -158,13 +157,12 @@ public override void SignIn(IList<ClaimsIdentity> identities, AuthenticationProp
                 throw new ArgumentNullException();
             }
             var handler = HttpAuthentication.Handler;
-            if (handler == null)
-            {
-                throw new InvalidOperationException("No authentication handlers present.");
-            }
 
             var signInContext = new SignInContext(identities, properties == null ? null : properties.Dictionary);
-            handler.SignIn(signInContext);
+            if (handler != null)
+            {
+                handler.SignIn(signInContext);
+            }
 
             // Verify all types ack'd
             IEnumerable<string> leftovers = identities.Select(identity => identity.AuthenticationType).Except(signInContext.Accepted);
@@ -181,13 +179,12 @@ public override void SignOut(IList<string> authenticationTypes)
                 throw new ArgumentNullException();
             }
             var handler = HttpAuthentication.Handler;
-            if (handler == null)
-            {
-                throw new InvalidOperationException("No authentication handlers present.");
-            }
 
             var signOutContext = new SignOutContext(authenticationTypes);
-            handler.SignOut(signOutContext);
+            if (handler != null)
+            {
+                handler.SignOut(signOutContext);
+            }
 
             // Verify all types ack'd
             IEnumerable<string> leftovers = authenticationTypes.Except(signOutContext.Accepted);