Skip to content

Conversation

LoopedBard3
Copy link
Contributor

Remove CitrineAMD as it has been decommissioned.

IP / role remapping
Application (old citrineamd) 10.0.0.106 -> 10.0.0.109 (asp-citrine-amd2)
Database / downstream 10.0.0.106 -> 10.0.0.103 (asp-citrine-db)
Load / secondary 10.0.0.106 -> 10.0.0.105 (asp-citrine-load)

Co-authored with CoPilot.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the decommissioned CitrineAMD server (10.0.0.106) and remaps its roles to other existing servers. The application role is now handled by asp-citrine-amd2 (10.0.0.109), while database/downstream operations are redirected to asp-citrine-db (10.0.0.103) and load/secondary operations to asp-citrine-load (10.0.0.105).

Key Changes:

  • Replaced all references to IP 10.0.0.106 with appropriate replacement IPs (10.0.0.109, 10.0.0.103, or 10.0.0.105) based on role
  • Updated endpoint URLs from asp-citrine-amd to the corresponding replacement servers
  • Removed profile definitions for aspnet-citrine-amd from configuration files

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/BenchmarksApps/BuildPerformance/buildperformance.yml Updated IP addresses and endpoints for aspnet-citrine-amd profile
src/Benchmarks/json.benchmarks.yml Updated IP addresses and endpoints for aspnet-citrine-amd profile
scenarios/aspnet.profiles.yml Remapped IPs and endpoints across multiple profiles; removed aspnet-citrine-amd profile definition
scenarios/aspnet.profiles.standard.yml Remapped IPs and endpoints across multiple profiles; removed aspnet-citrine-amd profile definition
scenarios/README.md Removed documentation entry for aspnet-citrine-amd server
build/prbenchmarks.runtime.linux_x64.config.yml Removed aspnet-citrine-amd profile configuration
build/prbenchmarks.aspnetcore.config.yml Removed aspnet-citrine-amd profile configuration
build/ci.profile.yml Removed amd-lin-app and amd-lin-load profile definitions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@LoopedBard3
Copy link
Contributor Author

Not sure if we want to rename the profiles that had the app endpoint switched to citrineamd2 to include the 2 in the name. Let me know if anyone has specific thoughts and I will update once an approach is agreed upon.

@LoopedBard3 LoopedBard3 marked this pull request as ready for review October 14, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants