Throw PlatformNotSupportedException in netstandard1.3
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- stop trying to use DCS in the JSON and XML formatters - if `UseDataContractSerializer` or `!UseXmlSerializer`: - `CanReadType(...)` and `CanWriteType(...)` always return `false` - `ReadFromStreamAsync(...)` and `WriteToStreamAsync(...)` always `throw` - change default XML formatter configuration to use `XmlSerializer` - adjust and disable tests in reaction - add tests of new `netstandard1.3` behavior - nits: - correct namespace of `SerializerConsistencyTests`; was alone in previous namespace - s/DataContractFormatter/XmlSerializerFormatter/ to reflect actual `XmlMediaTypeFormatter` test actions
dougbu
requested review from
javiercn,
mconnew,
MackinnonBuck,
mkArtakMSFT and
a team
|
/ping reviewers |
mconnew
approved these changes
Mar 6, 2023
|
Thanks @mconnew. Unfortunately, it appears only a select few have write access in this repo 😦 That means I need another reviewer. |
wtgodbe
approved these changes
Mar 6, 2023
dougbu
added a commit
to dougbu/AspNetWebStack
that referenced
this pull request
Mar 7, 2023
- follow up to aspnet#396 (unsure why new FxCop and "spelling" errors didn't fail that PR)
dougbu
added a commit
that referenced
this pull request
Mar 7, 2023
* Use `msbuild` from VS 2022 if available
- should ease local and TeamCity builds
- make `%InstallDir%` unquoted (unlike `%vswhere%`)
- shorten `%Path%` slightly
- nits:
- use script location more; no need to change directories
* React to new build issues
- follow up to #396
(unsure why new FxCop and "spelling" errors didn't fail that PR)
* Put `PortReserver` users into an xUnit collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseDataContractSerializeror!UseXmlSerializer:CanReadType(...)andCanWriteType(...)always returnfalseReadFromStreamAsync(...)andWriteToStreamAsync(...)alwaysthrowXmlSerializernetstandard1.3behaviorSerializerConsistencyTests; was alone in previous namespaceXmlMediaTypeFormattertest actions