feat(compiler): Add validation for empty structs #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added pass5 visitor to detect and report empty structs - Integrated new pass into build process - Added EmptyStruct variant to DiagnosticKind - Created test cases for empty struct validation - Fixed unused variable warning in blocks.rs Resolves: aspizu#150
|
aspizu
reviewed
Jun 1, 2025
| @@ -195,6 +196,9 @@ impl DiagnosticKind { | |||
| } => { | |||
| format!("struct {struct_name} is missing field {field_name}") | |||
| } | |||
| DiagnosticKind::EmptyStruct(name) => { | |||
| format!("struct {name} is empty; structs must have at least one field") | |||
| } | |||
There was a problem hiding this comment.
I'm being pedantic here, but annoys me that this is below the "catch-all" match arm.
There was a problem hiding this comment.
This test does not even work. Did you even run tests before committing?
| @@ -0,0 +1,9 @@ | |||
| // Test empty struct | |||
| type empty {} | |||
There was a problem hiding this comment.
This is not valid goboscript syntax, did you even read the documentation? Again, the tests will not pass. Compiling single-files is not supported.
| list empty mylist; | ||
|
|
||
| onflag { | ||
| say length(mylist); |
There was a problem hiding this comment.
This will still cause a panic. The original issue in question is not even fixed.
There was a problem hiding this comment.
This is fine, just move it inside one of the existing passes, preferably somewhere that already has relevant error reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #150