Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: support mypy #79

Closed
alexeagle opened this issue Dec 12, 2023 · 3 comments
Closed

[FR]: support mypy #79

alexeagle opened this issue Dec 12, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@alexeagle
Copy link
Member

What is the current behavior?

I adopted https://github.com/bazel-contrib/bazel-mypy-integration but haven't been doing much maintenance there.
Things get a lot simpler by using the linting mechanics from this repo, all we need is the mypy aspect.

Describe the feature

python/mypy#3912

@alexmirrington
Copy link

@alexeagle I've created a separate repo for Bazel MyPy rules over here which is heavily inspired by bazel-mypy-integration but adds a few missing features, namely:

  1. Support out of the box for protobuf/gRPC type stubs
  2. PEP-561 support for stubs-only packages.

I reckon it'd be great to see these extra features integrated into rules_lint, and am happy to contribute if this is something others might find useful!

@martis42
Copy link

@alexeagle
How does this issue play together with this commit of yours saying "there will be no mypy support in rules_lint": 944f143

Is this Feature Request now rejected?

And if so, is there some agreement in the community where mypy for Bazel should be maintained?
https://github.com/bazel-contrib/bazel-mypy-integration is not in a good shape, but could be improved. Actually, I have a PR open there with some proposed fixes.

I am happy too contribute to another project, but right now I am confused which project is the best bet.

@alexeagle
Copy link
Member Author

Hey @martis42 - I am waiting on an answer from @f0rmiga about where this can live, as it's funded by his company right now. I think likely options are rules_py - aspect-build/rules_py#235 or maybe get bazel-mypy-integration in better shape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants